Stop using "dummy_value" in native compute #20704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes all remaining uses of dummy_value. NB: there was a comment saying "Two instances of dummy_value should not be pointer equal, otherwise comparing them as terms would succeed" but when I tried to `assert (dummy_value () != dummy_value ())` the assertion failed...
silene
reviewed
Jun 3, 2025
silene
approved these changes
Jun 3, 2025
ppedrot
approved these changes
Jun 4, 2025
|
@coqbot merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB: there was a comment saying "Two instances of dummy_value should
not be pointer equal, otherwise comparing them as terms would succeed"
but when I tried to
assert (dummy_value () != dummy_value ())the assertion failed...