Add validate kwarg to RGlyph._loadFromGLIF
#623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I needed to be able to use this, it's part of the underlying `readGlyphFromString` API. I also would not oppose letting `_loadFromGLIF` take `**k 8000 wargs` which it can pass down to `readGlyphFromString` at maintainer's (@benkiel's?) option, but I do need something like this please. 🥺
Codecov Report
@@ Coverage Diff @@
## master #623 +/- ##
=======================================
Coverage 77.08% 77.08%
=======================================
Files 41 41
Lines 6010 6010
Branches 1045 1045
=======================================
Hits 4633 4633
Misses 1191 1191
Partials 186 186
|
|
Looks good. For right now let's just do the |
benkiel
approved these changes
Jan 5, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to be able to use this, it's part of the underlying
readGlyphFromStringAPI.I also would not oppose letting
_loadFromGLIFtake**kwargswhich it can pass down toreadGlyphFromStringat maintainer's (@benkiel's?) option, but I do need something like this please. 🥺