8000 force change the default layer name to the source defaultLayerName by typemytype · Pull Request #630 · robotools/fontParts · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

force change the default layer name to the source defaultLayerName #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 24, 2022
Merged

force change the default layer name to the source defaultLayerName #630

merged 3 commits into from
Feb 24, 2022

Conversation

typemytype
Copy link
Member

fixing #629 + test

@codecov
Copy link
codecov bot commented Feb 24, 2022 •
edited
Loading

Codecov Report

Merging #630 (116b8d6) into master (10c0245) will increase coverage by 0.60%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #630      +/-   ##
==========================================
+ Coverage   77.08%   77.69%   +0.60%     
==========================================
  Files          41       41              
  Lines        6010     6011       +1     
  Branches     1045     1045              
==========================================
+ Hits         4633     4670      +37     
+ Misses       1191     1147      -44     
- Partials      186      194       +8
Impacted Files Coverage Δ
Lib/fontParts/base/font.py 56.32% <100.00%> (+1.92%) ⬆️
Lib/fontParts/fontshell/image.py 93.75% <0.00%> (+4.16%) ⬆️
Lib/fontParts/fontshell/font.py 87.91% <0.00%> (+4.39%) ⬆️
Lib/fontParts/base/layer.py 65.35% <0.00%> (+7.01%) ⬆️
Lib/fontParts/fontshell/layer.py 87.80% <0.00%> (+12.19%) ⬆️

@benkiel benkiel merged commit d9c632f into master Feb 24, 2022
@benkiel benkiel deleted the fixCopyWithDifferentDefaultLayerName branch February 24, 2022 22:27
@benkiel benkiel mentioned this pull request Feb 24, 2022
Closed
@renovate renovate bot mentioned this pull request Mar 7, 2022
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benkiel benkiel benkiel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@typemytype @benkiel
0