8000 Change how anchor name value is gotten by benkiel · Pull Request #679 · robotools/fontParts · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Change how anchor name value is gotten #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Change how anchor name value is gotten #679

wants to merge 4 commits into from

Conversation

benkiel
Copy link
Member
@benkiel benkiel commented Jan 5, 2023

This should account for getting a value that doesn't exist in a math glyph, addressing #678

@benkiel benkiel requested a review from LettError January 5, 2023 16:45
@typemytype
Copy link
Member

the anchor.name attribute is optional according the spec, so is anchor.color, this could also be changed to anchor.get("color")

@benkiel
Copy link
Member Author
benkiel commented Jan 5, 2023

Agree, changed. Still not going to solve @LettError's problem, unfortunately

@justvanrossum
Copy link
Contributor

But look how toMathGlyph always sets name and color:

fontParts/Lib/fontParts/base/glyph.py

Lines 1641 to 1649 in f5250dc

for anchor in self.anchors:
d = dict(
x=anchor.x,
y=anchor.y,
name=anchor.name,
identifier=anchor.identifier,
color=anchor.color
)
mathGlyph.anchors.append(d)

I don't quite understand what "the spec" (which spec?) has to do with this.

@benkiel
Copy link
Member Author
benkiel commented Jan 5, 2023

@justvanrossum UFO Spec: https://unifiedfontobject.org/versions/ufo3/glyphs/glif/#anchor

@LettError
Copy link
Member

Would like to test, but how do I get this code to run locally?

@justvanrossum
Copy link
Contributor

UFO Spec

Perhaps I'm nitpicking, but what I mean is, this is just an object implementation, and it can decide by itself whether it demands those attributes to exist or not. Perhaps it requires the "missing" attributes to be substituted by None. The spec specifies the format, not how objects should be implemented.

@justvanrossum justvanrossum mentioned this pull request Jan 5, 2023
Open
@LettError
one step closer maybe
d28a58f 
Also use get() for the guideline name and guideline color. There is a new, additional traceback relating to color in the issue discussion.
@LettError
show what happens when getting the guideline color
b4cb042 
get the guideline color so we don't trip if the dict doesn't have it. Yet, this causes a different traceback
@benkiel
Copy link
Member Author
benkiel commented Jun 5, 2025

Was done in #838

@benkiel benkiel closed this Jun 5, 2025
@benkiel benkiel deleted the fix_anchor_name_math_glyph branch June 5, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LettError LettError Awaiting requested review from LettError

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benkiel @typemytype @justvanrossum @LettError
0