8000 Using non-reserved keywords in C++ and explicit casting of pointers by jcaille · Pull Request #79 · robotmedia/RMStore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Using non-reserved keywords in C++ and explicit casting of pointers #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2014

Conversation

jcaille
Copy link
Contributor
@jcaille jcaille commented May 26, 2014

Proposed fix for Issue 78.

I have made sure that the tests still pass, but haven't found the recommended linter for this project. If you point me to the right tool, I'll make sure that the modifications lints.

@hpique
Copy link
Member
hpique commented May 26, 2014

Thanks for noticing this, @jcaille.

Would you mind changing clazz to asn1Class?

@hpique
Copy link
Member
hpique commented May 26, 2014

Also, would you mind adding the following comment to the castings?

// Explicit casting to avoid errors when compiling as Objective-C++

@jcaille
Copy link
Contributor Author
jcaille commented May 27, 2014

No problem, I've done it. If there's anything more, let me know.

hpique added a commit that referenced this pull request May 27, 2014
Using non-reserved keywords in C++ and explicit casting of pointers
@hpique hpique merged commit b3617c1 into robotmedia:master May 27, 2014
@hpique
Copy link
Member
hpique commented May 27, 2014

Thanks @jcaille!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0