8000 Don't throw errors when HAL emits a warning by virtuald · Pull Request #144 · robotpy/robotpy-wpilib · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Nov 13, 2023. It is now read-only.

Don't throw errors when HAL emits a warning #144

Merged
merged 2 commits into from
Feb 25, 2015
Merged

Don't throw errors when HAL emits a warning #144

merged 2 commits into from
Feb 25, 2015

Conversation

virtuald
Copy link
Member

To test this, you can do the following:

git clone https://github.com/robotpy/robotpy-wpilib.git
cd robotpy-wpilib
git checkout hal-warning

On a linux/OSX system, or if you have MSYS installed on windows, you can run devtools/build_and_install.sh. If you don't have either of those, post a comment and I can write something up that will get you going.

@arilotter
Copy link
Contributor

Seems to have worked for me! I deployed it and it's not crashing anymore. On the other hand, I'm not getting any HAL warnings, so the problem might just have fixed itself (CAN is weird sometimes)

@arilotter
Copy link
Contributor

Even better! Just got a warning.

/usr/local/lib/python3.4/site-packages/wpilib/powerdistributionpanel.py:56: UserWarning: CTRE CAN Recieve Timeout
  return hal.getPDPTotalCurrent()

Works perfectly, thanks for the patch :)

virtuald added a commit that referenced this pull request Feb 25, 2015
@virtuald
Merge pull request #144 from robotpy/hal-warning
8edf3fc 
Don't throw errors when HAL emits a warning
@virtuald virtuald merged commit 8edf3fc into master Feb 25, 2015
@virtuald virtuald deleted the hal-warning branch February 25, 2015 21:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HAL STATUSFUNC should distinguish between warnings and errors
2 participants
@virtuald @arilotter
0