8000 Introduce hold mode that is running while hotkey is held down by robiot · Pull Request #41 · robiot/xclicker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Introduce hold mode that is running while hotkey is held down #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 5, 2022
Merged

Introduce hold mode that is running while hotkey is held down #41

merged 10 commits into from
Jun 5, 2022

Conversation

robiot
Copy link
Owner
@robiot robiot commented Jun 2, 2022

@robiot robiot marked this pull request as draft June 2, 2022 18:17
@robiot robiot marked this pull request as ready for review June 2, 2022 18:17
@robiot robiot marked this pull request as draft June 2, 2022 18:18
@robiot
Copy link
Owner Author
robiot commented Jun 5, 2022

image

Now it works! The right side looks weird because we have a little bit of free space.
I'm thinking of putting #38 there.

@robiot
Copy link
Owner Author
robiot commented Jun 5, 2022

I'll do that in another pull request! So anyone downloading straight from master will have a nice ui for a bit. 🤣

@robiot robiot marked this pull request as ready for review June 5, 2022 18:24
svemat01
svemat01 approved these changes Jun 5, 2022
View reviewed changes
Copy link
Contributor
@svemat01 svemat01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@robiot robiot merged commit 78536bb into master Jun 5, 2022
@robiot robiot deleted the chore/format branch June 5, 2022 18:28
robiot added a commit that referenced this pull request Oct 2, 2023
@robiot
Introduce hold mode that is running while hotkey is held down (#41)
00bfd94 
* Change name of current 'hold' mode to 'Button Hold'

* Add custom error macro to keep it more clean

* Remove brackets around one liner 'else statement'

* Move xapp_error to utils

* Use bitwise flags for mask_config

* Make get_next_key_state return the keystate too, start on logic

* New logic for start_stop_key_handler

Better handling for 2 keys #35, Make it work for both holdMode and not

* Add hold type ComboBox

* Remove debug comments and code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svemat01 svemat01 svemat01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robiot @svemat01
0