8000
Don't unpack if `UnpackLimit` is set to `0` by Cucumberrbob · Pull Request #817 · rogerfar/rdt-client · GitHub
More Web Proxy on the site http://driver.im/
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Validate against negative valuesSuggestion Impact:The suggestion was directly implemented in the commit. The exact code changes suggested (adding an if statement to check if settingUnpackLimit is negative and set it to 0 if so) were added to the code.
code diff:
+ if (settingUnpackLimit < 0)+ {+ settingUnpackLimit = 0;+ }
Consider validating that UnpackLimit is not negative. While 0 is now a valid value to disable unpacking, negative values could cause unexpected behavior. Add a check to ensure the value is at least 0.
Why: Adding a check to prevent negative values for UnpackLimit is a sensible safeguard that improves robustness, as negative limits could lead to undefined or erroneous behavior. This is a minor but meaningful improvement to input validation.
Medium
General
✅ Add clarifying commentSuggestion Impact:The suggestion was about explaining the difference in validation between downloadLimit and unpackLimit. The commit implemented validation for unpackLimit that allows 0 as a minimum value, which aligns with the suggestion's intent to clarify this behavior difference, though it used code rather than a comment.
code diff:
+ if (settingUnpackLimit < 0)+ {+ settingUnpackLimit = 0;+ }
The code enforces a minimum value of 1 for settingDownloadLimit but doesn't apply similar validation for settingUnpackLimit. Since the PR now supports 0 as a valid value to disable unpacking, consider adding a comment to explain this difference in validation approach.
var settingDownloadLimit = Settings.Get.General.DownloadLimit;
if (settingDownloadLimit < 1)
{
settingDownloadLimit = 1;
}
var settingUnpackLimit = Settings.Get.General.UnpackLimit;
+// UnpackLimit can be 0 to disable unpacking completely
[Suggestion processed]
Suggestion importance[1-10]: 5
__
Why: Adding a clarifying comment helps future maintainers understand why settingUnpackLimit is not validated like settingDownloadLimit, which improves code readability and maintainability, but it does not affect functionality or correctness.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Fixes #218
PR Type
enhancement, documentation
Description
Added ability to disable auto unpacking by setting
UnpackLimitto 0.Updated setting description to clarify disabling behavior.
Modified unpacking logic to skip when
UnpackLimitis 0.Changes walkthrough 📝
DbSettings.cs
Clarify UnpackLimit setting disables unpacking at 0server/RdtClient.Data/Models/Internal/DbSettings.cs
UnpackLimitto clarify that setting it to0 disables unpacking.
TorrentRunner.cs
Support disabling unpacking when UnpackLimit is 0server/RdtClient.Service/Services/TorrentRunner.cs
UnpackLimit.UnpackLimitis 0.