Add support for vector<vector> #3398

Levi0804 · 2025-03-05T15:29:56Z

Summary

This PR adds support to pass vector as transaction arguments. Please let me know if these changes look good and whether I should constrain the concrete type of inner vector to u8.

Closes #issue
[cli] Support pass vector<vector<u8>> as transaction arguments #3294

vercel · 2025-03-05T15:30:01Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
onchain-ai-chat	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 5, 2025 4:41pm
rooch-portal-v2.1	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 5, 2025 4:41pm
test-portal	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 5, 2025 4:41pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
rooch	⬜️ Ignored (Inspect)	Visit Preview		Mar 5, 2025 4:41pm

jolestar · 2025-03-05T15:42:13Z

Can you add a sample entry function in

https://github.com/rooch-network/rooch/blob/02567e201e0b16f34d61b96ecb2f01c9b173b801/examples/entry_function_arguments/sources/entry_function.move

and call the function in

rooch/crates/testsuite/features/cmd.feature

Lines 237 to 268 in cc64247

    
           Scenario: entry_function example 
        
             Given a server for entry_function 
        
             Then cmd: "move publish -p ../../examples/entry_function_arguments/  --named-addresses rooch_examples=default --json" 
        
             Then assert: "{{$.move[-1].execution_info.status.type}} == executed" 
        
             Then cmd: "move run --function default::entry_function::emit_bool --args bool:true  --json" 
        
             Then assert: "{{$.move[-1].execution_info.status.type}} == executed" 
        
             Then cmd: "move run --function default::entry_function::emit_u8 --args u8:3 --json" 
        
             Then assert: "{{$.move[-1].execution_info.status.type}} == executed" 
        
             Then cmd: "move run --function default::entry_function::emit_u8 --args 4u8  --json" 
        
             Then assert: "{{$.move[-1].execution_info.status.type}} == executed" 
        
             Then cmd: "move run --function default::entry_function::emit_address --args address:0x3242  --json" 
        
             Then assert: "{{$.move[-1].execution_info.status.type}} == executed" 
        
             Then cmd: "move run --function default::entry_function::emit_address --args @0x3242  --json" 
        
             Then assert: "{{$.move[-1].execution_info.status.type}} == executed" 
        
             Then cmd: "move run --function default::entry_function::emit_object_id --args object_id:0x3134  --json" 
        
             Then assert: "{{$.move[-1].execution_info.status.type}} == executed" 
        
             Then cmd: "move run --function default::entry_function::emit_string --args string:world  --json" 
        
             Then assert: "{{$.move[-1].execution_info.status.type}} == executed" 
        
             Then cmd: "move run --function default::entry_function::emit_vec_u8 --args "vector<u8>:2,3,4"  --json" 
        
             Then assert: "{{$.move[-1].execution_info.status.type}} == executed" 
        
             Then cmd: "move run --function default::entry_function::emit_vec_object_id --args "vector<object_id>:0x1324,0x41234,0x1234"  --json" 
        
             Then assert: "{{$.move[-1].execution_info.status.type}} == executed" 
        
             Then cmd: "move run --function default::entry_function::emit_mix --args 3u8 --args "vector<object_id>:0x2342,0x3132"  --json" 
        
             Then assert: "{{$.move[-1].execution_info.status.type}} == executed" 
        
             Then cmd: "move run --function default::entry_function::emit_object --args "object:default::entry_function::TestStruct"  --json" 
        
             Then assert: "{{$.move[-1].execution_info.status.type}} == executed" 
        
             Then cmd: "move run --function default::entry_function::emit_object_mut --args "object:default::entry_function::TestStruct"  --json" 
        
             Then assert: "{{$.move[-1].execution_info.status.type}} == executed" 
        
             Then stop the server

Levi0804 · 2025-03-05T16:49:45Z

Can you add a sample entry function in

https://github.com/rooch-network/rooch/blob/02567e201e0b16f34d61b96ecb2f01c9b173b801/examples/entry_function_arguments/sources/entry_function.move

and call the function in

rooch/crates/testsuite/features/cmd.feature

Lines 237 to 268 in cc64247

Scenario: entry_function example

Given a server for entry_function

Then cmd: "move publish -p ../../examples/entry_function_arguments/ --named-addresses rooch_examples=default --json"

Then assert: "{{$.move[-1].execution_info.status.type}} == executed"

Then cmd: "move run --function default::entry_function::emit_bool --args bool:true --json"

Then assert: "{{$.move[-1].execution_info.status.type}} == executed"

Then cmd: "move run --function default::entry_function::emit_u8 --args u8:3 --json"

Then assert: "{{$.move[-1].execution_info.status.type}} == executed"

Then cmd: "move run --function default::entry_function::emit_u8 --args 4u8 --json"

Then assert: "{{$.move[-1].execution_info.status.type}} == executed"

Then cmd: "move run --function default::entry_function::emit_address --args address:0x3242 --json"

Then assert: "{{$.move[-1].execution_info.status.type}} == executed"

Then cmd: "move run --function default::entry_function::emit_address --args @0x3242 --json"

Then assert: "{{$.move[-1].execution_info.status.type}} == executed"

Then cmd: "move run --function default::entry_function::emit_object_id --args object_id:0x3134 --json"

Then assert: "{{$.move[-1].execution_info.status.type}} == executed"

Then cmd: "move run --function default::entry_function::emit_string --args string:world --json"

Then assert: "{{$.move[-1].execution_info.status.type}} == executed"

Then cmd: "move run --function default::entry_function::emit_vec_u8 --args "vector<u8>:2,3,4" --json"

Then assert: "{{$.move[-1].execution_info.status.type}} == executed"

Then cmd: "move run --function default::entry_function::emit_vec_object_id --args "vector<object_id>:0x1324,0x41234,0x1234" --json"

Then assert: "{{$.move[-1].execution_info.status.type}} == executed"

Then cmd: "move run --function default::entry_function::emit_mix --args 3u8 --args "vector<object_id>:0x2342,0x3132" --json"

Then assert: "{{$.move[-1].execution_info.status.type}} == executed"

Then cmd: "move run --function default::entry_function::emit_object --args "object:default::entry_function::TestStruct" --json"

Then assert: "{{$.move[-1].execution_info.status.type}} == executed"

Then cmd: "move run --function default::entry_function::emit_object_mut --args "object:default::entry_function::TestStruct" --json"

Then assert: "{{$.move[-1].execution_info.status.type}} == executed"

Then stop the server

I've made these changes. Do they look good to you?

jolestar · 2025-03-06T02:09:17Z

crates/testsuite/features/cmd.feature

@@ -263,6 +263,8 @@ Feature: Rooch CLI integration tests
      Then assert: "{{$.move[-1].execution_info.status.type}} == executed"
      Then cmd: "move run --function default::entry_function::emit_object_mut --args "object:default::entry_function::TestStruct"  --json"
      Then assert: "{{$.move[-1].execution_info.status.type}} == executed"
+      Then cmd: "move run --function default::entry_function::emit_vec_vec_u8 --args "vector<vector<u8>>:std::vector[2,3,4],std::vector[5,6,7]"  --json"


Is this a valid format?

Tests failed due to this. I'm looking into it.

add support for vector<vector>

66566b1

Levi0804 requested review from jolestar and baichuan3 as code owners March 5, 2025 15:29

vercel bot deployed to Preview – onchain-ai-chat March 5, 2025 15:30 View deployment

vercel bot deployed to Preview – test-portal March 5, 2025 15:32 View deployment

Levi0804 mentioned this pull request Mar 5, 2025

[cli] Support pass vector<vector<u8>> as transaction arguments #3294

Open

vercel bot deployed to Preview – rooch-portal-v2.1 March 5, 2025 15:34 View deployment

add and call sample entry function

165f185

Levi0804 requested review from wow-sven, geometryolife and pause125 as code owners March 5, 2025 16:36

vercel bot deployed to Preview – rooch-portal-v2.1 March 5, 2025 16:38 View deployment

vercel bot deployed to Preview – test-portal March 5, 2025 16:41 View deployment

vercel bot deployed to Preview – onchain-ai-chat March 5, 2025 16:41 View deployment

jolestar reviewed Mar 6, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add support for vector<vector> #3398

Add support for vector<vector> #3398

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Add support for vector<vector> #3398

Are you sure you want to change the base?

Add support for vector<vector> #3398

Uh oh!

Conversation

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!