8000 Always import the editor.css by johanmolen · Pull Request #3248 · roots/sage · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Always import the editor.css #3248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2025
Merged

Always import the editor.css #3248

merged 1 commit into from
Mar 27, 2025

Conversation

johanmolen
Copy link
Contributor

Always import the editor.css instead of inlining it when Vite is not running hot.

For example @font-face calls require an absolute URL to the font when inlined, due to being called from within an iFrame.
I guess the same issue appears for images referenced within the CSS file.

Instead of putting absolute URL's into the CSS file we can just import the CSS file, that way it uses the hostname of the CSS file.

@github-actions github-actions bot added the php Pull requests that update PHP code label Mar 21, 2025
@Log1x Log1x merged commit 20d1d07 into roots:main Mar 27, 2025
3 checks passed
@Log1x
Copy link
Member
Log1x commented Mar 27, 2025

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Log1x Log1x Log1x approved these changes

Assignees
No one assigned
Labels
php Pull requests that update PHP code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johanmolen @Log1x
0