10000 Add support for linux riscv64 musl by fossdd · Pull Request #5726 · rollup/rollup · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support for linux riscv64 musl #5726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 23, 2025
Merged

Add support for linux riscv64 musl #5726

merged 4 commits into from
Mar 23, 2025

Conversation

fossdd
Copy link
Contributor
@fossdd fossdd commented Nov 15, 2024

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no
  • N.A.

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Supports linux riscv on musl systems like Alpine Linux.

@vercel Vercel
Copy link
vercel bot commented Nov 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 10:58pm

@fossdd fossdd marked this pull request as ready for review November 15, 2024 08:21
@leso-kn
Copy link
Contributor
leso-kn commented Mar 9, 2025

@lukastaegert Have these changes been reviewed yet? :)

From what I see it's only a few lines to enable the support, which would be interesting in the current effort to port dotnet9 to linux-musl-riscv64.

@lukastaegert
Copy link
Member

@leso-kn so far this did no build. If you have suggestions how to fix it, please go ahead.

@leso-kn
Copy link
Contributor
leso-kn commented Mar 11, 2025 •
edited
Loading

After a bit of testing it turned out the build was failing due to an incomplete cross-build environment.

✔️ Putting a sysroot with libgcc_s and libc in place makes the pipeline pass (see job 38587902393).

@fossdd Feel free to cherry-pick leso-kn 1bd00c8 onto fossdd:linux-riscv64-musl.

@fossdd fossdd force-pushed the linux-riscv64-musl branch from ebab8c6 to ceb71ff Compare March 11, 2025 19:11
@leso-kn
Copy link
Contributor
leso-kn commented Mar 12, 2025

@lukastaegert This should be ready now :)

Tested on a VisionFive2 successfully building react-rollup-boilerplate

lukastaegert
lukastaegert approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member
@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I wonder it this should also be contributed upstream in the docker image? In the meantime, once CI passes I will release this!

@codecov Codecov
Copy link
codecov bot commented Mar 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.55%. Comparing base (ab7bfa8) to head (d12ae31).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5726   +/-   ##
=======================================
  Coverage   98.55%   98.55%           
=======================================
  Files         269      269           
  Lines        8584     8584           
  Branches     1472     1472           
=======================================
  Hits         8460     8460           
  Misses         92       92           
  Partials       32       32

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@leso-kn
Copy link
Contributor
leso-kn commented Mar 13, 2025 •
edited
Loading

Cool, that's great news, thank you! And the riscv64gc-unknown-linux-musl job passed!

@lukastaegert In case you were referring to the Lint and Audit job, feel free to re-run with leso-kn 3e3e908 cherry-picked which fixes npm audit (see job 38698536946)

@leso-kn leso-kn force-pushed the linux-riscv64-musl branch from ceb71ff to d12ae31 Compare March 19, 2025 22:56
@leso-kn
Copy link
Contributor
leso-kn commented Mar 19, 2025

@lukastaegert I've added d12ae31 which fixes npm audit in case you want to run again, the pipeline should pass

@lukastaegert lukastaegert enabled auto-merge March 23, 2025 14:07
@lukastaegert
Copy link
Member

Ah, sorry for the wait, hopefully this will merge now

@lukastaegert lukastaegert added this pull request to the merge queue Mar 23, 2025
@lukastaegert lukastaegert removed this pull request from the merge queue due to a manual request Mar 23, 2025
@lukastaegert lukastaegert merged commit 43cb194 into rollup:master Mar 23, 2025
41 checks passed
@github-actions GitHub Actions
Copy link

This PR has been released as part of rollup@4.37.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fossdd @leso-kn @lukastaegert
0