8000 Fix more variable deconflicting issues by lukastaegert · Pull Request #5728 · rollup/rollup · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix more variable deconflicting issues #5728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 15, 2024
Merged

Fix more variable deconflicting issues #5728

merged 2 commits into from
Nov 15, 2024

Conversation

lukastaegert
Copy link
Member

…key or default side effect

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This resolves various situations I found where the corresponding variables would not be included in a necessary situation, leaving to situations where the deconflicting logic fails.

@vercel Vercel
Copy link
vercel bot commented Nov 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 4:19pm

@github-actions GitHub Actions
Copy link
github-actions bot commented Nov 15, 2024 •
edited
Loading

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#side-effects-in-patterns

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-16slxac0z-rollup-js.vercel.app/repl/?pr=5728

@github-actions GitHub Actions
Copy link
github-actions bot commented Nov 15, 2024 •
edited
Loading

Performance report

  • BUILD: 7870ms, 747 MB
    • initialize: 0ms, 26.8 MB
    • generate module graph: 3167ms, 560 MB
      • generate ast: 1497ms (-39ms, -2.5%), 554 MB
    • sort and bind modules: 450ms, 606 MB
    • mark included statements: 4234ms, 750 MB
      • treeshaking pass 1: 2790ms, 744 MB
      • treeshaking pass 2: 516ms, 748 MB
      • treeshaking pass 3: 460ms, 748 MB
      • treeshaking pass 4: 454ms, 750 MB
  • GENERATE: 905ms, 992 MB
    • initialize render: 0ms, 884 MB
    • generate chunks: 87ms, 898 MB
      • optimize chunks: 0ms, 886 MB
    • render chunks: 803ms, 967 MB
    • transform chunks: 16ms, 992 MB
    • generate bundle: 0ms, 992 MB

@lukastaegert lukastaegert mentioned this pull request Nov 15, 2024
Merged
9 tasks
@codecov Codecov
Copy link
codecov bot commented Nov 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.84%. Comparing base (aaf38b7) to head (40023e7).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5728   +/-   ##
=======================================
  Coverage   98.84%   98.84%           
=======================================
  Files         259      259           
  Lines        8218     8226    +8     
  Branches     1395     1396    +1     
=======================================
+ Hits         8123     8131    +8     
  Misses         63       63           
  Partials       32       32

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert lukastaegert merged commit 6c68455 into master Nov 15, 2024
40 checks passed
@lukastaegert lukastaegert deleted the side-effects-in-patterns branch November 15, 2024 16:37
@github-actions GitHub Actions
Copy link

This PR has been released as part of rollup@4.27.2. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lukastaegert
0