8000 Reduce max hash size to 21 by lukastaegert · Pull Request #5723 · rollup/rollup · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Reduce max hash size to 21 #5723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 15, 2024
Merged

Reduce max hash size to 21 #5723

merged 2 commits into from
Nov 15, 2024

Conversation

lukastaegert
Copy link
Member

In certain cases, the maximum length was actually 21, resulting in unexpected file names and off-by-one-sourcemaps.

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes Technically yes, but I would still be willing to release this in a minor version as 22 was broken and not working as expected.
  • no

List any relevant issue numbers:

Description

This reduces the maximum allowed hash size from 22 to 21 as for base64, sometimes the hash size would be just 21, resulting in unexpected files names and off-by-one source maps.

@lukastaegert
Reduce max hash size to 21
3defcc5 
In certain cases, the maximum length was actually 21, resulting in unexpected
file names and off-by-one-sourcemaps.
@vercel Vercel
Copy link
vercel bot commented Nov 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 5:35am

@github-actions GitHub Actions
Copy link
github-actions bot commented Nov 14, 2024 •
edited
Loading

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-5720_max_hash_size

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-bc29rfhjm-rollup-js.vercel.app/repl/?pr=5723

@github-actions GitHub Actions
Copy link

Performance report

  • BUILD: 8659ms, 728 MB
    • initialize: 0ms, 26.3 MB
    • generate module graph: 3294ms, 553 MB
      • generate ast: 1534ms, 546 MB
    • sort and bind modules: 461ms, 596 MB
    • mark included statements: 4904ms, 728 MB
      • treeshaking pass 1: 1663ms, 694 MB
      • treeshaking pass 2: 801ms, 723 MB
      • treeshaking pass 3: 315ms, 8000 724 MB
      • treeshaking pass 4: 290ms, 725 MB
      • treeshaking pass 5: 335ms, 726 MB
      • treeshaking pass 6: 280ms, 731 MB
      • treeshaking pass 7: 261ms, 731 MB
      • treeshaking pass 8: 250ms, 734 MB
      • treeshaking pass 9: 228ms, 733 MB
      • treeshaking pass 10: 231ms, 730 MB
      • treeshaking pass 11: 225ms, 728 MB
  • GENERATE: 924ms, 978 MB
    • initialize render: 0ms, 871 MB
    • generate chunks: 101ms, 876 MB
      • optimize chunks: 0ms, 873 MB
    • render chunks: 823ms, 956 MB
    • transform chunks: 18ms, 978 MB
    • generate bundle: 0ms, 978 MB

@codecov Codecov
Copy link
codecov bot commented Nov 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.00%. Comparing base (7ec926c) to head (8ef17d6).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5723   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files         258      258           
  Lines        8070     8070           
  Branches     1360     1360           
=======================================
  Hits         7990     7990           
  Misses         53       53           
  Partials       27       27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert lukastaegert merged commit 50697b8 into master Nov 15, 2024
26 of 27 checks passed
@lukastaegert lukastaegert deleted the gh-5720_max_hash_size branch November 15, 2024 05:36
@github-actions GitHub Actions
Copy link

This PR has been released as part of rollup@4.27.0. You can test it via npm install rollup.

@github-actions github-actions bot mentioned this pull request Nov 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In certain special cases, [hash:22] may not meet expectations
1 participant
@lukastaegert
0