8000 Revert object tree-shaking (#5420) until some issues have been resolved by lukastaegert · Pull Request #5736 · rollup/rollup · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert object tree-shaking (#5420) until some issues have been resolved #5736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2024
Merged

Revert object tree-shaking (#5420) until some issues have been resolved #5736

merged 1 commit into from
Nov 18, 2024

Conversation

lukastaegert
Copy link
Member

This reverts commit a9acb57.

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

I will revert the feature for now until #5733, #5734, #5735 and #5480 (comment) have been fixed. We also need to see if we can improve upon #5729.

@vercel Vercel
Copy link
vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 3:50pm

@lukastaegert lukastaegert merged commit 10bc150 into master Nov 18, 2024
27 checks passed
@lukastaegert lukastaegert deleted the revert-property-tree-shaking branch November 18, 2024 15:52
@github-actions GitHub Actions
Copy link
github-actions bot commented Nov 18, 2024 •
edited
Loading

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#revert-property-tree-shaking

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-8xhaf0thi-rollup-js.vercel.app/repl/?pr=5736

@github-actions GitHub Actions
Copy link

Performance report

  • BUILD: 8096ms (+427ms, +5.6%), 731 MB
    • initialize: 0ms, 26.6 MB
    • generate module graph: 3099ms, 552 MB (-2%)
      • generate ast: 1487ms, 545 MB
    • sort and bind modules: 433ms, 597 MB
    • mark included statements: 4565ms (+461ms, +11.2%), 731 MB
      • treeshaking pass 1: 1543ms (-1167ms, -43.1%), 697 MB (-6%)
      • treeshaking pass 2: 735ms (+234ms, +46.7%), 715 MB (-5%)
      • treeshaking pass 3: 292ms (-153ms, -34.3%), 720 MB (-3%)
      • treeshaking pass 4: 268ms (-173ms, -39.2%), 726 MB (-3%)
      • treeshaking pass 5: 318ms, 730 MB, new stage
      • treeshaking pass 6: 260ms, 726 MB, new stage
      • treeshaking pass 7: 244ms, 731 MB, new stage
      • treeshaking pass 8: 237ms, 729 MB, new stage
      • treeshaking pass 9: 216ms, 728 MB, new stage
      • treeshaking pass 10: 218ms, 730 MB, new stage
      • treeshaking pass 11: 215ms, 731 MB, new stage
  • GENERATE: 874ms, 979 MB
    • initialize render: 0ms, 870 MB
    • generate chunks: 85ms, 877 MB
      • optimize chunks: 0ms, 871 MB
    • render chunks: 770ms, 956 MB
    • transform chunks: 16ms, 979 MB
    • generate bundle: 0ms, 979 MB

@codecov Codecov
Copy link
codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.00%. Comparing base (a503a4d) to head (03aff3f).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5736      +/-   ##
==========================================
+ Coverage   98.84%   99.00%   +0.16%     
==========================================
  Files         259      258       -1     
  Lines        8226     8070     -156     
  Branches     1396     1360      -36     
==========================================
- Hits         8131     7990     -141     
+ Misses         63       53      -10     
+ Partials       32       27       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@github-actions GitHub Actions
Copy link

This PR has been released as part of rollup@4.27.3. You can test it via npm install rollup.

@job79 job79 mentioned this pull request Nov 19, 2024
Closed
@Rugvip Rugvip mentioned this pull request Nov 21, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lukastaegert
0