8000 return UnknownValue if the usedbranch is unkown and the path is not empty by TrickyPi · Pull Request #5846 · rollup/rollup · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

return UnknownValue if the usedbranch is unkown and the path is not empty #5846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2025
Merged

return UnknownValue if the usedbranch is unkown and the path is not empty #5846

merged 1 commit into from
Feb 17, 2025

Conversation

TrickyPi
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #5845

Description

@vercel Vercel
Copy link
vercel bot commented Feb 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2025 11:58am

@github-actions GitHub Actions
Copy link
github-actions bot commented Feb 16, 2025 •
edited
Loading

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix/5845

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-mrr6drpxc-rollup-js.vercel.app/repl/?pr=5846

@TrickyPi TrickyPi mentioned this pull request Feb 16, 2025
Closed
@github-actions GitHub Actions
Copy link

Performance report

  • BUILD: 7152ms, 746 MB
    • initialize: 0ms, 28.1 MB
    • generate module graph: 2786ms, 560 MB
      • generate ast: 1278ms, 554 MB
    • sort and bind modules: 392ms, 601 MB
    • mark included statements: 3978ms, 746 MB
      • treeshaking pass 1: 2332ms, 743 MB
      • treeshaking pass 2: 459ms, 746 MB
      • treeshaking pass 3: 396ms, 747 MB
      • treeshaking pass 4: 390ms, 744 MB
      • treeshaking pass 5: 383ms, 746 MB
  • GENERATE: 713ms, 986 MB
    • initialize render: 0ms, 883 MB
    • generate chunks: 71ms, 893 MB
      • optimize chunks: 0ms, 888 MB
    • render chunks: 626ms, 963 8000 MB
    • transform chunks: 16ms, 986 MB
    • generate bundle: 0ms, 986 MB

@codecov Codecov
Copy link
codecov bot commented Feb 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.54%. Comparing base (f9c52f8) to head (12bf837).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5846   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files         269      269           
  Lines        8544     8545    +1     
  Branches     1466     1467    +1     
=======================================
+ Hits         8420     8421    +1     
  Misses         92       92           
  Partials       32       32

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lukastaegert
lukastaegert approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member
@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was definitely an oversight, good fix 👍

@lukastaegert lukastaegert added this pull request to the merge queue Feb 17, 2025
Merged via the queue into master with commit ba692fe Feb 17, 2025
41 checks passed
@lukastaegert lukastaegert deleted the fix/5845 branch February 17, 2025 05:53
@github-actions GitHub Actions
Copy link

This PR has been released as part of rollup@4.34.8. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect tree shaking
2 participants
@TrickyPi @lukastaegert
0