Fix prop inclusion with try-catch-deoptimization #5842
Conversation
- When call arguments are included, do not call "include" on the "this" argument again, as this will already be included at the call site. This allows to make the inclusion logic more straightforward - create shared helper to do that - if a call/new/tagged template expression is called with recursive inclusion, do not specifically include the arguments. Instead, if an identifier is included recursively, then include an unknown path of the variable.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#fix_try_statement_return_propsNotice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust. or load it into the REPL: |
Performance report
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5842 +/- ##
==========================================
+ Coverage 98.53% 98.54% +0.01%
==========================================
Files 269 269
Lines 8547 8544 -3
Branches 1466 1466
==========================================
- Hits 8422 8420 -2
+ Misses 93 92 -1
Partials 32 32 ☔ View full report in Codecov by Sentry. |
|
This PR has been released as part of rollup@4.34.7. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
tryCatchDeoptimization:trueremoves object properties that are used intrybodies #5839Description
This cleans up and refines how argument inclusion and try-catch deoptimization handle prop inclusion. I wanted to do this anyway for another forthcoming PR but it turns out, this already solves #5839.