8000 Add jsx parameter to parseAsync in native.wasm.js by TrickyPi · Pull Request #5866 · rollup/rollup · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add jsx parameter to parseAsync in native.wasm.js #5866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2025
Merged

Add jsx parameter to parseAsync in native.wasm.js #5866

merged 1 commit into from
Mar 1, 2025

Conversation

TrickyPi
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #5865

Description

That’s an oversight; we forgot to modify the native.wasm.js file while supporting the JSX.

@vercel Vercel
Copy link
vercel bot commented Feb 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 2:29pm

@github-actions GitHub Actions
Copy link
github-actions bot commented Feb 28, 2025 •
edited
Loading

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix/5865

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-pqgdkolt3-rollup-js.vercel.app/repl/?pr=5866

@github-actions GitHub Actions
Copy link

Performance report

  • BUILD: 7330ms, 749 MB
    • initialize: 0ms, 28.1 MB
    • generate module graph: 2817ms, 560 MB
      • generate ast: 1281ms, 552 MB
    • sort and bind modules: 408ms, 603 MB
    • mark included statements: 4098ms, 749 MB
      • treeshaking pass 1: 2410ms, 743 MB
      • treeshaking pass 2: 473ms, 747 MB
      • treeshaking pass 3: 406ms, 746 MB
      • treeshaking pass 4: 400ms, 745 MB
      • treeshaking pass 5: 395ms, 749 MB
  • GENERATE: 750ms, 986 MB
    • initialize render: 0ms, 882 MB
    • generate chunks: 72ms, 892 MB
      • optimize chunks: 0ms, 892 MB
    • render chunks: 660ms, 962 MB
    • transform chunks: 16ms, 986 MB
    • generate bundle: 0ms, 986 MB

@TrickyPi TrickyPi mentioned this pull request Feb 28, 2025
Closed
@codecov Codecov
Copy link
codecov bot commented Feb 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.54%. Comparing base (d3e79bd) to head (03bb7e4).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5866   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files         269      269           
  Lines        8545     8545           
  Branches     1467     1467           
=======================================
  Hits         8421     8421           
  Misses         92       92           
  Partials       32       32

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lukastaegert
lukastaegert approved these changes Mar 1, 2025
View reviewed changes
Copy link
Member
@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@lukastaegert lukastaegert added this pull request to the merge queue Mar 1, 2025
Merged via the queue into master with commit be66eb9 Mar 1, 2025
41 checks passed
@lukastaegert lukastaegert deleted the fix/5865 branch March 1, 2025 06:25
@github-actions GitHub Actions
Copy link
github-actions bot commented Mar 1, 2025

This PR has been released as part of rollup@4.34.9. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jsx.mode: "preserve" doesn't work on @rollup/wasm-node
2 participants
@TrickyPi @lukastaegert
0