8000 Fix `treeshake: false` breaking destructured namespace imports by Skn0tt · Pull Request #5908 · rollup/rollup · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix treeshake: false breaking destructured namespace imports #5908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 12, 2025
Merged

Fix treeshake: false breaking destructured namespace imports #5908

merged 2 commits into from
Apr 12, 2025

Conversation

Skn0tt
Copy link
Contributor
@Skn0tt Skn0tt commented Apr 8, 2025

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

setMergedNamespaces is skipped if includeAllExports(false) is called prior to includeAllExports(true), which somehow only happens with treeshake: false.

@vercel Vercel
Copy link
vercel bot commented Apr 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2025 1:23pm

@Skn0tt Skn0tt mentioned this pull request Apr 8, 2025
Closed
@codecov Codecov
Copy link
codecov bot commented Apr 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.56%. Comparing base (328fa2d) to head (a37b8a7).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5908   +/-   ##
=======================================
  Coverage   98.56%   98.56%           
=======================================
  Files         270      270           
  Lines        8688     8688           
  Branches     1488     1488           
=======================================
  Hits         8563     8563           
  Misses         92       92           
  Partials       33       33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Skn0tt Skn0tt changed the title Fix no treeshake react Fix treeshake: false breaking destructured namespace import Apr 9, 2025
@Skn0tt Skn0tt changed the title Fix treeshake: false breaking destructured namespace import Fix treeshake: false breaking destructured namespace imports Apr 9, 2025
lukastaegert
lukastaegert approved these changes Apr 12, 2025
View reviewed changes
Copy link
Member
@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for looking into this!

@lukastaegert lukastaegert added this pull request to the merge queue Apr 12, 2025
Merged via the queue into rollup:master with commit aba2ea9 Apr 12, 2025
41 checks passed
@github-actions GitHub Actions
Copy link

This PR has been released as part of rollup@4.40.0. You can test it via npm install rollup.

@github-actions github-actions bot mentioned this pull request Apr 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

treeshake: false breaks destructured namespace import
2 participants
@Skn0tt @lukastaegert
0