8000 consider the dynamic import within a TLA call expression as a TLA import by TrickyPi · Pull Request #5900 · rollup/rollup · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

consider the dynamic import within a TLA call expression as a TLA import #5900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2025
Merged

consider the dynamic import within a TLA call expression as a TLA import #5900

merged 1 commit into from
Apr 12, 2025

Conversation

TrickyPi
Copy link
Member
@TrickyPi TrickyPi commented Apr 2, 2025

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

resolves #5884

Description

Consider the dynamic import within a TLA call expression as a TLA import, which could cover most of the cases in Vite.

@vercel Vercel
Copy link
vercel bot commented Apr 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2025 5:45am

@github-actions GitHub Actions
Copy link
github-actions bot commented Apr 2, 2025 •
edited
Loading

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix/5884

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-jb86tu2q7-rollup-js.vercel.app/repl/?pr=5900

@github-actions GitHub Actions
Copy link
github-actions bot commented Apr 2, 2025 •
edited
Loading

Performance report

  • BUILD: 7666ms, 745 MB
    • initialize: 0ms, 28.1 MB
    • generate module graph: 2901ms, 561 MB
      • generate ast: 1289ms, 554 MB
    • sort and bind modules: 415ms, 604 MB
    • mark included statements: 4359ms, 745 MB
      • treeshaking pass 1: 2559ms, 746 MB
      • treeshaking pass 2: 505ms, 745 MB
      • treeshaking pass 3: 435ms, 747 MB
      • treeshaking pass 4: 431ms, 748 MB
      • treeshaking pass 5: 428ms, 745 MB
  • GENERATE: 780ms, 988 MB
    • initialize render: 0ms, 884 MB
    • generate chunks: 78ms, 896 MB
      • optimize chunks: 0ms, 889 MB
    • render chunks: 681ms, 962 MB
    • transform chunks: 17ms, 988 MB
    • generate bundle: 0ms, 988 MB

@codecov Codecov
Copy link
codecov bot commented Apr 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.56%. Comparing base (86e1ccd) to head (303eaae).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5900   +/-   ##
=======================================
  Coverage   98.56%   98.56%           
=======================================
  Files         270      270           
  Lines        8688     8690    +2     
  Branches     1488     1487    -1     
=======================================
+ Hits         8563     8565    +2     
  Misses         92       92           
  Partials       33       33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

melissamforbs
melissamforbs reviewed Apr 3, 2025
View reviewed changes
Copy link
@melissamforbs melissamforbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge

lukastaegert
lukastaegert approved these changes Apr 12, 2025
View reviewed changes
8000
Copy link
Member
@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me!

@lukastaegert lukastaegert enabled auto-merge April 12, 2025 05:43
@lukastaegert lukastaegert added this pull request to the merge queue Apr 12, 2025
Merged via the queue into master with commit 19fb519 Apr 12, 2025
42 checks passed
@lukastaegert lukastaegert deleted the fix/5884 branch April 12, 2025 06:45
@github-actions GitHub Actions
Copy link

This PR has been released as part of rollup@4.40.0. You can test it via npm install rollup.

@github-actions github-actions bot mentioned this pull request Apr 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melissamforbs melissamforbs melissamforbs approved these changes

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect chunking when code has top-level await import wrapped with a function
3 participants
@TrickyPi @lukastaegert @melissamforbs
0