8000 fix(assetFileNames): reduce max hash size to 21 by shulaoda · Pull Request #5921 · rollup/rollup · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(assetFileNames): reduce max hash size to 21 #5921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2025
Merged

fix(assetFileNames): reduce max hash size to 21 #5921

merged 1 commit into from
Apr 26, 2025

Conversation

shulaoda
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This reduces the maximum allowed hash size from 22 to 21 as for base64, sometimes the hash size would be just 21, resulting in unexpected files names and off-by-one source maps.

@vercel Vercel
Copy link
vercel bot commented Apr 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2025 5:32pm

@codecov Codecov
Copy link
codecov bot commented Apr 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.55%. Comparing base (1f2d579) to head (8f5246c).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5921   +/-   ##
=======================================
  Coverage   98.55%   98.55%           
=======================================
  Files         270      270           
  Lines        8692     8692           
  Branches     1488     1489    +1     
=======================================
  Hits         8566     8566           
  Misses         93       93           
  Partials       33       33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lukastaegert
Copy link
Member

In the future, we might consider to warn about this, but for now I think it is fine.

@lukastaegert lukastaegert added this pull request to the merge queue Apr 26, 2025
Merged via the queue into rollup:master with commit 8e0d034 Apr 26, 2025
41 checks passed
@github-actions GitHub Actions
Copy link

This PR has been released as part of rollup@4.40.1. You can test it via npm install rollup.

@github-actions github-actions bot mentioned this pull request Apr 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The maximum length of the hash for assetFileNames should be 21
2 participants
@shulaoda @lukastaegert
0