8000 fix: generate the separate chunk for the entry module with explicated chunk filename or name by TrickyPi · Pull Request #5923 · rollup/rollup · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: generate the separate chunk for the entry module with explicated chunk filename or name #5923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 27, 2025
Merged

fix: generate the separate chunk for the entry module with explicated chunk filename or name #5923

merged 2 commits into from
Apr 27, 2025

Conversation

TrickyPi
Copy link
Member
@TrickyPi TrickyPi commented Apr 15, 2025 •
edited
Loading

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

resolves #5907
resolves #5906

Description

If an entry module has a specified filename or name in this.emitFile() call or input options, we should generate a separate chunk for it

@vercel Vercel
Copy link
vercel bot commented Apr 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2025 6:07am

@github-actions GitHub Actions
Copy link
github-actions bot commented Apr 15, 2025 •
edited
Loading

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix/5907

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-ls5b8n2hg-rollup-js.vercel.app/repl/?pr=5923

@github-actions GitHub Actions
Copy link
github-actions bot commented Apr 15, 2025 •
edited
Loading

Performance report

  • BUILD: 7157ms, 745 MB
    • initialize: 0ms, 28.2 MB
    • generate module graph: 2776ms, 561 MB
      • generate ast: 1286ms (+26ms, +2.1%), 554 MB
    • sort and bind modules: 394ms, 604 MB
    • mark included statements: 3996ms, 745 MB
      • treeshaking pass 1: 2363ms, 740 MB
      • treeshaking pass 2: 459ms, 744 MB
      • treeshaking pass 3: 397ms, 743 MB
      • treeshaking pass 4: 388ms, 752 MB
      • treeshaking pass 5: 385ms, 745 MB
  • GENERATE: 727ms, 986 MB
    • initialize render: 0ms, 884 MB
    • generate chunks: 71ms, 895 MB
      • optimize chunks: 0ms, 889 MB
    • render chunks: 636ms, 964 MB
    • transform chunks: 16ms, 986 MB
    • generate bundle: 0ms, 986 MB

@codecov Codecov
Copy link
codecov bot commented Apr 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.55%. Comparing base (99d4bee) to head (fb043eb).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5923   +/-   ##
=======================================
  Coverage   98.55%   98.55%           
=======================================
  Files         270      270           
  Lines        8692     8694    +2     
  Branches     1489     1490    +1     
=======================================
+ Hits         8566     8568    +2     
  Misses         93       93           
  Partials       33       33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lukastaegert
lukastaegert reviewed Apr 26, 2025
View reviewed changes
@lukastaegert lukastaegert added this pull request to the merge queue Apr 27, 2025
Merged via the queue into master with commit 03f34b0 Apr 27, 2025
42 checks passed
@lukastaegert lukastaegert deleted the fix/5907 branch April 27, 2025 05:22
@github-actions GitHub Actions
Copy link

This PR has been released as part of rollup@4.40.1. You can test it via npm install rollup.

This was referenced Apr 28, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Regression 4.39.0] The "paths[1]" argument must be of type string. Received undefined Some entry chunks are not generated
2 participants
@TrickyPi @lukastaegert
0