8000 chore: add new `./package.json` entry by JounQin · Pull Request #5931 · rollup/rollup · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: add new ./package.json entry #5931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2025
Merged

chore: add new ./package.json entry #5931

merged 2 commits into from
Apr 26, 2025

Conversation

JounQin
Copy link
Contributor
@JounQin JounQin commented Apr 20, 2025

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

N/A

Description

./package.json is a common entry for checking metadata quicky by other packages.

By the way, I just developed https://github.com/un-ts/napi-postinstall which helps to workaround the npm's bug npm/cli#4828, if you agree I'd like to raise a PR for it just like

https://github.com/unrs/unrs-resolver/blob/8772685286bf19d8e23f5a1f7b0381ba3c185eea/npm/package.json#L48

@vercel Vercel
Copy link
vercel bot commented Apr 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2025 4:32am

@lukastaegert
Copy link
Member

Thanks for the PR, but I must admit I see this for the first time. Is there some official documentation to explain this feature?

@JounQin
Copy link
Contributor Author
JounQin commented Apr 21, 2025 •
edited
Loading

Thanks for the PR, but I must admit I see this for the first time. Is there some official documentation to explain this feature?

@lukastaegert Did you mean require('rollup/package.json')? It's just a custom export for consumers, for example:

https://github.com/un-ts/napi-postinstall/blob/bbdef3a10c69c856b47175842eae39374cce7a13/src/index.ts#L183

@lukastaegert
Copy link
Member

Ah, I was confused, yes, this is fine.

@lukastaegert lukastaegert enabled auto-merge April 26, 2025 04:31
@codecov Codecov
Copy link
codecov bot commented Apr 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.55%. Comparing base (7fc5036) to head (7b386ee).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5931   +/-   ##
=======================================
  Coverage   98.55%   98.55%           
=======================================
  Files         270      270           
  Lines        8692     8692           
  Branches     1488     1488           
=======================================
  Hits         8566     8566           
  Misses         93       93           
  Partials       33       33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lukastaegert lukastaegert added this pull request to the merge queue Apr 26, 2025
Merged via the queue into rollup:master with commit 99d4bee Apr 26, 2025
41 checks passed
@JounQin JounQin deleted the patch-1 branch April 26, 2025 05:20
@github-actions GitHub Actions
Copy link

This PR has been released as part of rollup@4.40.1. You can test it via npm install rollup.

@JounQin
Copy link
Contributor Author
JounQin commented May 14, 2025

@lukastaegert

Would integrating with https://github.com/un-ts/napi-postinstall be acceptable? If you agree I'd like to raise a PR for it. It resolves legacy npm bug issue of optionalDependencies, and will support install wasi for webcontainer soon.

See also unrs/unrs-resolver#101 and un-ts/napi-postinstall#17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JounQin @lukastaegert
0