8000 ci: use node 24 by btea · Pull Request #5949 · rollup/rollup · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ci: use node 24 #5949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

ci: use node 24 #5949

wants to merge 6 commits into from

Conversation

btea
Copy link
Contributor
@btea btea commented May 7, 2025

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

https://github.com/nodejs/node/releases/tag/v24.0.0

@vercel Vercel
Copy link
vercel bot commented May 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2025 2:08am

@codecov Codecov
Copy link
codecov bot commented May 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.55%. Comparing base (02da7ef) to head (717e187).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5949   +/-   ##
=======================================
  Coverage   98.55%   98.55%           
=======================================
  Files         270      270           
  Lines        8718     8719    +1     
  Branches     1495     1496    +1     
=======================================
+ Hits         8592     8593    +1     
  Misses         93       93           
  Partials       33       33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@btea
Copy link
Contributor Author
btea commented May 7, 2025 •
edited
Loading

Node24 is also the same as node 22.12.0. The error message is different from 22.11.0, which will cause the test to fail.

rollup/.github/workflows/build-and-tests.yml

Lines 501 to 503 in 02da7ef

- '18.20.0'
# There is a bug in 22.12.0 that sometimes makes the loadConfigFile tests fail
- '22.11.0'

In response to this situation, I modified the judgment condition of the test case. However, I am not sure whether this is appropriate.

@lukastaegert
Copy link
Member

I wonder if the problem is the native support for requiring ES modules. Then maybe we need to skip the test Node >= 22, or run a different test instead.

@btea
Copy link
Contributor Author
btea commented May 10, 2025 •
edited
Loading

It seems that the warning messages given by the node when loading es module in versions 22.11.0 and 24.0.0 are different, resulting in different results of the following judgment logic, which leads to test failure. ref nodejs/node#56628

rollup/cli/run/loadConfigFile.ts

Lines 63 to 67 in 7536ffb

const handleWarning = (warning: Error): void => {
if (warning.message.includes('To load an ES module')) {
cannotLoadEsm = true;
}
};

22.11.0 screen

image

24.0.0 screen

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@btea @lukastaegert
0