8000 Improve approximation of coarse sourcemap segments by TrickyPi · Pull Request #5985 · rollup/rollup · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve approximation of coarse sourcemap segments #5985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 19, 2025
Merged

Improve approximation of coarse sourcemap segments #5985

merged 3 commits into from
Jun 19, 2025

Conversation

TrickyPi
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #5955

Description

Relevant comment: #5961 (comment)

Currently, esbuild is generating some coarse segments, though it may produce more precise ones in the future evanw/esbuild#4189. Since we already have a fallback logic in place, we only need to extend it to cover the esbuild case.

@vercel Vercel
Copy link
vercel bot commented Jun 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2025 3:06am

@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 14, 2025 •
edited
Loading

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix/tweak-sourcemaps-merge

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-o0kkk7jpm-rollup-js.vercel.app/repl/?pr=5985

@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 14, 2025 •
edited
Loading

Performance report

  • BUILD: 7046ms, 789 MB (+4%)
    • initialize: 0ms, 24.6 MB
    • generate module graph: 2532ms (-141ms, -5.3%), 571 MB
      • generate ast: 1147ms (-46ms, -3.9%), 562 MB
    • sort and bind modules: 401ms, 618 MB
    • mark included statements: 4001ms (+80ms, +2.0%), 789 MB (+4%)
      • treeshaking pass 1: 2371ms (+86ms, +3.7%), 770 MB (+2%)
      • treeshaking pass 2: 459ms, 785 MB
      • treeshaking pass 3: 395ms, 775 MB (+2%)
      • treeshaking pass 4: 382ms, 783 MB
      • treeshaking pass 5: 380ms, 789 MB (+4%)
  • GENERATE: 699ms, 1.04 GB
    • initialize render: 0ms, 894 MB
    • generate chunks: 58ms, 912 MB
      • optimize chunks: 0ms, 902 MB
    • render chunks: 621ms, 1 GB (+3%)
    • transform chunks: 16ms, 1.04 GB
    • generate bundle: 0ms, 1.04 GB

@codecov Codecov
Copy link
codecov bot commented Jun 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.78%. Comparing base (5dcce11) to head (e77df78).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5985   +/-   ##
=======================================
  Coverage   98.78%   98.78%           
=======================================
  Files         270      270           
  Lines        8735     8745   +10     
  Branches     1510     1512    +2     
=======================================
+ Hits         8629     8639   +10     
  Misses         73       73           
  Partials       33       33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TrickyPi TrickyPi force-pushed the fix/tweak-sourcemaps-merge branch from 8870b91 to e77df78 Compare June 16, 2025 03:05
lukastaegert
lukastaegert approved these changes Jun 19, 2025
View reviewed changes
Copy link
Member
@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure there might be some performance impact but it looks reasonable to me to go with it.

@lukastaegert lukastaegert added this pull request to the merge queue Jun 19, 2025
Merged via the queue into master with commit 95b53ee Jun 19, 2025
42 checks passed
@lukastaegert lukastaegert deleted the fix/tweak-sourcemaps-merge branch June 19, 2025 05:10
@github-actions GitHub Actions
Copy link

This PR has been released as part of rollup@4.44.0. You can test it via npm install rollup.

@github-actions github-actions bot mentioned this pull request Jun 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect combined sourcemaps for JSX opening element token
2 participants
@TrickyPi @lukastaegert
0