Debug/fix watch pipeline #5982
Debug/fix watch pipeline #5982
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#fix-watch-testNotice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust. or load it into the REPL: |
Performance report
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5982 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 270 270
Lines 8734 8734
Branches 1509 1509
=======================================
Hits 8627 8627
Misses 73 73
Partials 34 34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR addresses sporadic failures in the watch-mode tests on macOS by adding a brief delay before aborting, and enhances the CLI test harness to support repeated runs and richer timeout diagnostics.
- Add a
waithelper and a short delay in theabortOnStderrhook so the child’sonErrorcommand has time to write before termination. - Wrap each test in a loop keyed off
config.repeatand includestdout/stderrin the timeout rejection message.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/cli/samples/watch/watch-event-hooks-error/_config.js | Imported wait, made abortOnStderr async, and inserted a 300 ms pause before killing. |
| test/cli/index.js | Introduced a for loop for config.repeat, adjusted test descriptions, and improved timeout errors with logs. |
Comments suppressed due to low confidence (1)
test/cli/index.js:30
- [nitpick] Consider renaming the loop variable 'run' to a noun like 'attempt' or 'iteration' for clarity, since 'run' can be ambiguous as a verb.
for (let run = 0; run < (config.repeat || 1); run++) {
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
This PR has been released as part of rollup@4.41.2. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
On MacOS Node 24, one watch test is failing repeatedly.