8000 Fix sourcemap file resolution for Next.js apps with --next parameter by TheDevFactory · Pull Request #24 · rollbar/rollbar-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix sourcemap file resolution for Next.js apps with --next parameter #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

TheDevFactory
Copy link
Member
@TheDevFactory TheDevFactory commented Jun 24, 2025

Problem: When using --next parameter to zip sourcemaps, the CLI failed with "ADM-ZIP: File not found" errors for Next.js projects. This occurred because sourcemap URLs like ".next/static/xxx.js.map" were being resolved relative to the JavaScript file's directory instead of the project root.

Solution: Updated extractMapPath() to intelligently resolve sourcemap paths:

  • Paths containing '/' (like ".next/static/...") resolve relative to project root
  • Simple filenames resolve relative to the JS file's directory

This ensures Next.js and other framework sourcemaps are found correctly when creating zip uploads.

Example of the error in commandline:
Screenshot 2025-06-24 at 16 08 38

🤖 Generated with Claude Code

Description of the change

Please include a summary of the change and which issues are fixed.
Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Shortcut stories and GitHub issues (delete irrelevant)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

Problem: When using --next parameter to zip sourcemaps, the CLI failed with
"ADM-ZIP: File not found" errors for Next.js projects. This occurred because
sourcemap URLs like ".next/static/xxx.js.map" were being resolved relative
to the JavaScript file's directory instead of the project root.

Solution: Updated extractMapPath() to intelligently resolve sourcemap paths:
- Paths containing '/' (like ".next/static/...") resolve relative to project root
- Simple filenames resolve relative to the JS file's directory

This ensures Next.js and other framework sourcemaps are found correctly when
creating zip uploads.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@TheDevFactory TheDevFactory deleted the FixNextJSZIPUpload branch June 25, 2025 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0