8000 build(deps): Bump github.com/quic-go/quic-go from 0.39.4 to 0.42.0 by dependabot[bot] · Pull Request #1617 · rollkit/rollkit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

build(deps): Bump github.com/quic-go/quic-go from 0.39.4 to 0.42.0 #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dependabot[bot]
Copy link
Contributor
@dependabot dependabot bot commented on behalf of github Apr 2, 2024

Bumps github.com/quic-go/quic-go from 0.39.4 to 0.42.0.

Release notes

Sourced from github.com/quic-go/quic-go's releases.

v0.42.0

New Features

  • added a qlog tracer for events that happen before / outside of established connection: #4305

Notable Changes

  • added a ClientHelloInfo.AddrVerified field: #4360
  • move callback controlling address verification (VerifySourceAddress) to the Transport: #4253 and #4362
  • connections that are closed before being accepted are not removed from the server's accept queue: #4245
  • http3: added a RoundTripOpt.CheckSettings callback to check the server's SETTINGS: #4355
  • http3: send the HTTP/3 settings value for Extended CONNECT (RFC 9220): #4341
  • http3: don't modify the user's quic.Config to enable QUIC datagram support: #4340

Fixes

  • mitigate a memory exhaustion attack against QUIC's connection ID mechanism: #4369
  • don't delay acknowledgments for packets during the handshake: #4279
  • fix deadlock when closing both Listener and Transport: #4332
  • fix handling of IPv4-mapped IPv6 addresses: #4309
  • fix duplicate logging of the key_discarded event for Handshake packets: #4274
  • send CONNECTION_REFUSED when refusing connections: #4250
  • http3: tighten validation logic for the :protocol pseudo header: #4261

What's Changed

... (truncated)

Commits
  • 4a99b81 close connection when an abnormally large number of frames are queued (#4369)
  • 9971fed use Transport.VerifySourceAddress to control the Retry Mechanism (#4362)
  • 497d3f5 http3: add a RoundTripOpt to check the server's SETTINGS frame (#4355)
  • ca787d6 add an AddrVerified field to the ClientHelloInfo (#4360)
  • f147639 update gomock to v0.4.0 (#4361)
  • 06b4214 remove unused ReceiveStream.CloseRemote method (#4357)
  • 5fd5d77 Merge pull request #4305 from quic-go/qlog-tracer
  • 30e01b9 use the transport tracer in integration tests
  • 55c05ac qlog: log sent packets outside of a QUIC connection
  • aff90a6 qlog: log sent Version Negotiation packets
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Copy link
Contributor
coderabbitai bot commented Apr 2, 2024

Important

Auto Review Skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Manav-Aggarwal
Manav-Aggarwal previously approved these changes Apr 2, 2024
@MSevey MSevey enabled auto-merge April 8, 2024 15:53
tzdybal
tzdybal previously approved these changes Apr 11, 2024
@MSevey
Copy link
Contributor
MSevey commented Apr 12, 2024

@dependabot rebase

Bumps [github.com/quic-go/quic-go](https://github.com/quic-go/quic-go) from 0.39.4 to 0.42.0.
- [Release notes](https://github.com/quic-go/quic-go/releases)
- [Changelog](https://github.com/quic-go/quic-go/blob/master/Changelog.md)
- [Commits](quic-go/quic-go@v0.39.4...v0.42.0)

---
updated-dependencies:
- dependency-name: github.com/quic-go/quic-go
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/quic-go/quic-go-0.42.0 branch from 29ced08 to da9fe1b Compare April 12, 2024 15:12
@MSevey
Copy link
Contributor
MSevey commented Apr 17, 2024

this is somehow breaking.

% git checkout dependabot/go_modules/github.com/quic-go/quic-go-0.42.0
branch 'dependabot/go_modules/github.com/quic-go/quic-go-0.42.0' set up to track 'origin/dependabot/go_modules/github.com/quic-go/quic-go-0.42.0'.
Switched to a new branch 'dependabot/go_modules/github.com/quic-go/quic-go-0.42.0'

% make install
go: downloading google.golang.org/grpc v1.63.0
go: downloading google.golang.org/genproto/googleapis/rpc v0.0.0-20240227224415-6ceb2ff114de
--> Installing Rollkit CLI
# github.com/libp2p/go-libp2p/p2p/transport/quicreuse
../../go/pkg/mod/github.com/libp2p/go-libp2p@v0.32.2/p2p/transport/quicreuse/config.go:15:2: unknown field RequireAddressValidation in struct literal of type quic.Config
make: *** [install] Error 1

@MSevey
Copy link
Contributor
MSevey commented Apr 17, 2024

Similar errors in GA

run golangci-lint
  Running [/home/runner/golangci-lint-1.57.2-linux-amd64/golangci-lint run --out-format=github-actions --timeout 10m] in [] ...
  Error: undefined: libp2p (typecheck)
  
  level=warning msg="[config_reader] The configuration option `run.skip-dirs` is deprecated, please use `issues.exclude-dirs`."
  level=warning msg="[runner/nolint] Found unknown linters in //nolint directives: "
  
  Error: issues found
  Ran golangci-lint in 3260ms

@MSevey
Copy link
Contributor
MSevey commented Apr 17, 2024

Seems like this is a breaking change.
Will try bumping to 0.41 instead

@MSevey MSevey dismissed stale reviews from Manav-Aggarwal and tzdybal via f4a5142 April 17, 2024 14:42
@MSevey MSevey self-assigned this Apr 22, 2024
@MSevey
Copy link
Contributor
MSevey commented Apr 22, 2024

need to figure out bumping to 0.42

@tzdybal
Copy link
Member
tzdybal commented Apr 25, 2024

We should bump quic and libp2p at the same time. See: #1646

@tzdybal tzdybal closed this Apr 25, 2024
Copy link
Contributor Author
dependabot bot commented on behalf of github Apr 25, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/github.com/quic-go/quic-go-0.42.0 branch April 25, 2024 20:25
github-merge-queue bot pushed a commit that referenced this pull request Apr 26, 2024
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.

NOTE: PR titles should follow semantic commits:
https://www.conventionalcommits.org/en/v1.0.0/
-->

## Overview

This PR updates dependencies and bumps go version used in CI.

Replaces #1617, #1624.

<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 

Ex: Closes #<issue number>
-->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Documentation**
- Updated the Go version requirement in the README to reflect
compatibility changes.
- **Chores**
- Updated the Go version in the CI workflow to ensure consistent
performance and compatibility.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants
0