This repository was archived by the owner on Aug 31, 2023. It is now read-only.
Rome init missing argument #1515
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ematipico
reviewed
May 19, 2021
| @@ -96,7 +96,7 @@ export default createServerCommand<Flags>({ | |||
| // - second part creates a basic configuration file and and the .editorconfig | |||
| // part of the command where we check if a configuration already exists | |||
| if (checkProject) { | |||
| req.expectArgumentLength(1); | |||
| req.expectArgumentLength(1); // TODO: Does this belong here at all? | |||
There was a problem hiding this comment.
This isn't correct. Probably expectArgumentLength now works as expected. Although, even if we removed this, there would be few issues that I need to solve. I am already working on them, I will have PR open soon.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ematipico in response to #1418 (comment)
I'm wondering what you expect this argument to be?