8000 Adaptation to java11 modular system. by DavidShahbazyan · Pull Request #305 · ronmamo/reflections · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adaptation to java11 modular system. #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Adaptation to java11 modular system. #305

wants to merge 2 commits into from

Conversation

DavidShahbazyan
Copy link

Hi, I've done little changes to make the lib available for using in java11 modular apps.

@DavidShahbazyan
Copy link
Author

Hi All.
Hope you're doing well.

This is my first pull request, and I'm not sure what should I do the next as the build was failed because the test had tried to build a Java 11 app using lower java version. Could anyone help me with this, please?

Sorry for inconvenience.
Thanks in advance.

@DavidShahbazyan DavidShahbazyan mentioned this pull request Jan 3, 2021
Open
@WoodenAndrew
Copy link

If you're adding module system support atleast do it properly instead of this halfassed solution.

@DavidShahbazyan
Copy link
Author

If you're adding module system support atleast do it properly instead of this halfassed solution.

Oh! I see, sorry. As you could probably noticed in my comment, this was the first time I've tried to make any lib better. So most probably this was not the best implementation.

I'd like to know if there are any plans of migration to Java 11?

Thanks

@astubbs astubbs mentioned this pull request Sep 3, 2021
Merged
@ronmamo
Copy link
Owner
ronmamo commented Oct 25, 2021

closing this for now. hey @DavidShahbazyan contact me ronmamo at gmail, let's work on somethin

@ronmamo ronmamo closed this Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavidShahbazyan @WoodenAndrew @ronmamo
0