Implemented PHPUnit, Comply to PSR4, Allow custom \Redis objects #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All classes must go into _ at least _ a vendor namespace. Would be trivial to add Travis CI script to this. As the self-centered dev i am, i added myself to the list of authors
|
Ping @ronnylt |
signe
referenced
this pull request
in signe/redlock-php
Oct 13, 2015
|
Since @ronnylt has abandoned the project, I've created a new codebase and packagist entry signe/redlock-php which contains this pull request, and more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a bunch of commits that i needed for this to run against my system.
You might want to cherry-pick what makes sense.
RedLockclass into a vender namespaceRedLock(might break backwards compatibility for people usingdev-masterto install package.redis-serverinstances used in testing.\Redisobject instead of the[$host, $port, $timeout]array. (if user is already dealing with a connection, why open a new one)\Redisobjects can now be passed, the$tokenused to unlock the lock must be serialized with the\Redisobjects serializer. This is important if the user is using something than the default serializer (like igbinary).