[WIP] feature(rosenpass): integrate assert_tv and derandomize protocol.rs #604
Conversation
Fix nix configuration
Remove feature tv Stream-line integration of test-vectors further: Now cargo test --all-features should work Switched to released assert_tv version
|
I had noticed that the rosenpass CI uses I have fixed this design error by removing the requirement to add a feature as a client of This let to a more streamlined integration elsewhere as well and many |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #604 +/- ##
=======================================
Coverage ? 88.22%
=======================================
Files ? 102
Lines ? 12734
Branches ? 240
=======================================
Hits ? 11235
Misses ? 1496
Partials ? 3 ☔ View full report in Codecov by Sentry. |
I'm not familiar with |
Here is a WIP solution to integrate the assert_tv crate and derandomize the protocol.rs module.
This PR is mainly meant as a starting point to explore how to make derandomization as non-disruptiv as possible and also not clutter the entire code-base with
#cfg[ ]macros and feature flags.The way derandomization would work is with the help of 3 macros:
#[test_vec(..)]: proc macro that wraps a test and sets up a test_vec environment, which is stored and later accessed through thread-local storage, and finilizes it at the end.tv_const!(..): macro that defines a constant value in the test vector. When test vectors are initialized, these values are serialized from the observed runtime values. When test vectors are checked, these values are loaded and injected at runtime and replace random variables.tv_output!(..): macro that checks a result with the one found in the test vector. When test vectors are initialized, these values are also serialized from the observed runtime values. In contrast, when test vectors are checked, the runtime values are compared with the values loaded from the test vector file. If they don't match it will error.Here is a
test_vectest: crypto_server_test_vectors.rsYou may run this test with the following command
Test vectors are frozen as files and checked into the repository. For example: crypto_server_test_vector_1.json
You may run this test in
initmode (by setting an env variable) to overwrite the values stores in this test vector file:Let me know what you think about the proposal, what you like to see improved or changed, or if you have any questions.