Dev/wucke13 nix maintenance #640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cebec58 to
6697a8a
Compare
6697a8a to
a6e2c96
Compare
|
@wucke13 Is this ready to merge from your end? |
f40288e to
32f6a24
Compare
32f6a24 to
91bb9f1
Compare
|
@koraa Yes, if CI runs through, I'm all good for merge |
91bb9f1 to
1c01605
Compare
Add a treefmt setup for a single-entry point format-everything system. To use it, simply run `nix fmt`. This will in term run nixfmt, prettier and rustfmt. Signed-off-by: wucke13 <wucke13+github@gmail.com>
This implicates a change from nixpkgs-fmt to nixfmt. Nixfmt will become the new standard on nix formatting, sanctioned by the nixpkgs. To verify that these changes are purely in whitespace, but not semantic: git diff --ignore-all-space -w HEAD^! That will only show newline changes, make the diffing somewhat easier. Signed-off-by: wucke13 <wucke13+github@gmail.com>
By now it is possible to use cargo-llvm-cov with the nixpkgs built-in llvm tools, thus no need for a nightly rust with the llvm-tools-preview. Therefore, fenix as a dependency is removed. Signed-off-by: wucke13 <wucke13+github@gmail.com>
Before this change, the patch release was left open. This patch pinpoints it exactly, down to the patch release. Signed-off-by: wucke13 <wucke13+github@gmail.com>
This check requires a specific toolchain version, and to get that, we introduce oxalica's rust-overlay. Signed-off-by: wucke13 <wucke13+github@gmail.com>
It was missing from the fullEnv nativeBuildInputs. Also, reorder the cargo subcommands in that list alphabetically. Signed-off-by: wucke13 <wucke13+github@gmail.com>
There still is ambiguity between the script's output and the current CI pipelines, usage not recommend. Signed-off-by: wucke13 <wucke13+github@gmail.com>
1c01605 to
50501f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on changes from #638.