8000 Windows binary missing · Issue #555 · roswell/roswell · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Windows binary missing #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jcs090218 opened this issue Jun 1, 2023 · 3 comments · Fixed by #565
Closed

Windows binary missing #555

jcs090218 opened this issue Jun 1, 2023 · 3 comments · Fixed by #565

Comments

@jcs090218
Copy link

The last two releases do not have Windows' binary. What happened? 🤔

Latest release with Windows binary available:
@snmsts
Copy link
Member
snmsts commented Jun 1, 2023

I don't know how CI broken but it's because of CI and I didn't care because it's easy to install roswell on mingw64 environment. https://packages.msys2.org/package/mingw-w64-x86_64-roswell?repo=mingw64

@jcs090218
Copy link
Author

Thank you for your information. I personally don't recommend people using mingw64 since most ported software is fragile and ends up with okayish or bad UX. 😓

@jcs090218 jcs090218 mentioned this issue Jun 4, 2023
Closed
toracle added a commit to toracle/roswell that referenced this issue Sep 9, 2023
@toracle
fix windows build script (roswell#555)
bbea2d8
@toracle toracle mentioned this issue Sep 9, 2023
Merged
snmsts pushed a commit that referenced this issue Sep 24, 2023
@toracle
fix windows build script (#555) (#565)
08ca16d
@toracle
Copy link
Contributor
toracle commented Sep 25, 2023 •
edited
Loading

I found that windows build was still failing after #565 was merged. I looked into it and found that there were two windows build files, .github/workflows/windows.yml and .github/workflows/build.yml, that were very similar. I only fixed one of them (windows.yml).

So, I think there are two possible solutions:

  • They are duplicated, due to some historical reason, so we can remove one (build.yml?)
  • They are not duplicated, but intentional. So, we need to apply Fix github action build script for windows #565 patch (install autotools) to build.yml as well.

I’m not sure about the purpose of build.yml, so maybe someone from the maintainers can explain it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix github action build script for windows toracle/roswell
3 participants
@snmsts @toracle @jcs090218
0