8000 Fix incorrect range check for PC offset values by dxrcy · Pull Request #33 · rozukke/lace · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix incorrect range check for PC offset values #33

New 8000 issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 20, 2024
Merged

Fix incorrect range check for PC offset values #33

merged 2 commits into from
Sep 20, 2024

Conversation

dxrcy
Copy link
Contributor
@dxrcy dxrcy commented Sep 20, 2024 •
edited
Loading

Fixes #30
Extends the allowable PCOffset range from -255..=255 to -256..=255.

@rozukke rozukke added bug Something isn't working behaviour This doesn't seem right labels Sep 20, 2024
@rozukke rozukke merged commit 067d278 into rozukke:main Sep 20, 2024
3 checks passed
@dxrcy dxrcy deleted the pcoffset-fix branch September 21, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
behaviour This doesn't seem right bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Off-by-one error for negative PC offset values
2 participants
@dxrcy @rozukke
0