10000 Use `--features` option instead of env vars by dxrcy · Pull Request #59 · rozukke/lace · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use --features option instead of env vars #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2025
Merged

Use --features option instead of env vars #59

merged 2 commits into from
Feb 20, 2025

Conversation

dxrcy
Copy link
Contributor
@dxrcy dxrcy commented Feb 15, 2025

Remove all environment variable code, replacing env.rs with the similarly structured features.rs.
Enable 'stack' extension with --features stack for lace, lace run, and lace compile.
Supports future addition of features, such as inline OS.

rozukke
rozukke reviewed Feb 15, 2025
View reviewed changes
Copy link
Owner
@rozukke rozukke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no way to de-dupe the 3 copies of the features flag in the clap Args?

@dxrcy
Copy link
Contributor Author
dxrcy commented Feb 15, 2025

Is there no way to de-dupe the 3 copies of the features flag in the clap Args?

Looked it up, and found #[command(flatten)]. Perfect!

This struct might also be used for --minimal in the debugger branch, although lace compile --minimal won't have any special behaviour.

@rozukke rozukke merged commit a512484 into rozukke:main Feb 20, 2025
3 checks passed
@dxrcy dxrcy deleted the feature-flags branch March 6, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rozukke rozukke rozukke left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dxrcy @rozukke
0