8000 Update __init__.py added support for IP8M type camera like model IP8M-2796E-AI by alpauna · Pull Request #405 · rroller/dahua · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update __init__.py added support for IP8M type camera like model IP8M-2796E-AI #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2024
Merged

Update __init__.py added support for IP8M type camera like model IP8M-2796E-AI #405

merged 1 commit into from
Oct 30, 2024

Conversation

alpauna
Copy link
Contributor
@alpauna alpauna commented Oct 30, 2024

Modified the or to add a starts with on the model looking for IP8M in the model name.

@alpauna
Copy link
Contributor Author
alpauna commented Oct 30, 2024

Tested on my IP8M-2796E-AI camera and it works great.
SecurityLightAdded

@rroller rroller merged commit 52adba8 into rroller:main Oct 30, 2024
@rroller
Copy link
Owner
rroller commented Oct 30, 2024

Thanks!

rroller added a commit that referenced this pull request Nov 2, 2024
@rroller
Revert "Update __init__.py (#405)"
f40ae9b 
This reverts commit 52adba8.
@rroller
Copy link
Owner
rroller commented Nov 2, 2024

Sorry I had to revert this change. See #410
Can you try to figure out a safer way to load this

@alpauna
Copy link
Contributor Author
alpauna commented Nov 8, 2024

So would it be safer to be more specific on the model IP8M-2796E so
or self.model.startswith("IP8M-2796E")
since it appears to be impacting certain models of IP8M cameras hate to be so specific but I lost some functionality by the rollback.

alpauna pushed a commit to alpauna/dahua that referenced this pull request Nov 8, 2024
Update init with security camera IP8M-2796Efeature for
d6cdd4c 
Addressed issues
rroller#405
@alpauna alpauna mentioned this pull request Nov 8, 2024
Merged
rroller pushed a commit that referenced this pull request Nov 10, 2024
@alpauna
Re Added Security Light for more specific models IP8M-2796E (#416)
38bb0a4 
* Update __init__.py

* Update init with security camera IP8M-2796Efeature for

Addressed issues
#405

---------

Co-authored-by: Allen Pauna <apauna@alshowto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alpauna @rroller
0