Betaflight changes to 160315 #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup temp files and add them to .gitignore
Output all profiles and rateprofiles in cli dump
# Conflicts: # src/main/io/rc_controls.h # src/main/io/serial_cli.c # src/main/io/serial_msp.c # src/main/version.h
|
I like the idea of enabling use_pwm_rate by default. Setting the PWM rate to 2.6KHz should be safe for all OS125 and MS ESCs. The RFC will need an update to support this. |
|
Can confirm working for Sparky2 with no oneshot, can't test Revo due to ripping of my usb port from it :( |
|
Is everyone happy for this to be merged? |
|
ok from me on targets i could verify :) |
|
Enabling use_pwm_rate by default will cause brushed motors to start during FC initialization. |
|
Hi @MJ666 - it is only enabled by default for F4 targets 👍 |
|
You can see here #117 we have bushed F4 targets but I have an fix in the PWM PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has an issue where looptime is too quick for Oneshot125. use_pwm_rate must be enabled for oneshot to work.
Will look to enabling by default and setting it at a safe minimum for 125 to work.