8000 Improved errors and warnings with `cli::cli_[abort|warn]()` by rich-iannone · Pull Request #963 · rstudio/gt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improved errors and warnings with cli::cli_[abort|warn]() #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Jun 15, 2022

Conversation

rich-iannone
Copy link
Member

With this PR, we are aiming to obtain improved formatting of errors and warnings by using the cli framework (cli::cli_[abort|warn]()). It's going to be a virtually 1:1 match to the older formatting but the styling improvements will lead to an overall better consistency in the messaging.

@rich-iannone rich-iannone changed the title Improved errors and warning with cli::cli_[abort|warn]() Improved errors and warnings with cli::cli_[abort|warn]() Jun 15, 2022
@rich-iannone rich-iannone marked this pull request as ready for review June 15, 2022 13:36
@rich-iannone rich-iannone requested a review from cscheid June 15, 2022 14:39
Copy link
Member
@cscheid cscheid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rich-iannone rich-iannone merged commit 7a6186d into master Jun 15, 2022
@rich-iannone rich-iannone deleted the improved-errors branch June 15, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0