8000 Latex Unicode Conversion by thebioengineer · Pull Request #1996 · rstudio/gt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Latex Unicode Conversion #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

thebioengineer
Copy link
Collaborator

Summary

Thank you for contributing to gt! To make this process easier for everyone, please explain the context and purpose of your contribution. Also, list the changes made to the existing code or documentation.

Related GitHub Issues and PRs

  • Ref: #

Checklist

This PR relies on updates from #1995 first, but incorporates updating unicode text into viable latex. There are a number of issues open related to this for currency, symbols, etc. Will link to them later.

Merge branch 'latex_newline' into latex_unicode_conversion

# Conflicts:
#	NEWS.md
Copy link
Collaborator
@olivroy olivroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ellis ! Thank you so much for working on this. If you don't mind, could you make sure the 2 PRs are exclusive? to facilitate review..

I see that you added the options latex_header_repeat in both PRs. and the latex() helper in both..

NEWS.md Outdated
Comment on lines 31 to 33
* Improvements to options for LaTeX including repeating Headers, removing top and bottom lines, applying font sizes, and line breaks (@thebioengineer, #1630, #1061, #1767)

* Add `latex()` function to let users write the LaTeX they wish to see in the table cell or text (@thebioengineer)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This belongs in the other PR ?

@thebioengineer
Copy link
Collaborator Author

Hi Ellis ! Thank you so much for working on this. If you don't mind, could you make sure the 2 PRs are exclusive? to facilitate review..

I see that you added the options latex_header_repeat in both PRs. and the latex() helper in both..

Yeah, I can try, apologies, I had gotten a few commit in and realized I had branched off the other PR and forgot to update it here.

Merge branch 'master' into latex_unicode_conversion

# Conflicts:
#	NEWS.md
@thebioengineer
Copy link
Collaborator Author

now that #1995 has been merged in, this PR should only reflect the updates to handle unicode. Looking into how to make the oldrel-4 work. Seems to be how it used to handle unicode.

@olivroy
Copy link
Collaborator
olivroy commented Jun 18, 2025

Overall, I agree with this. I am just surprised this isn't already done by commonmark. Would this fix any existing issue?

@thebioengineer
8000 Copy link
Collaborator Author

I can double check for one, I thought I had seen one about currency not working before, but now I can't find it. I know I had some problems and can open an issue if that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0