8000 refactor: use lodash-es instead of lodash by simonguo · Pull Request #4085 · rsuite/rsuite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: use lodash-es instead of lodash #4085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: next
Choose a base branch
from
Open

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
simonguo
Copy link
Member

This pull request focuses on replacing the usage of the lodash library with lodash-es across various files in the codebase. The changes include updating import statements and modifying dependencies in the package.json file.

Dependency Updates:

  • package.json: Replaced lodash and its plugins with lodash-es and updated related type definitions. [1] [2] [3]

Codebase Modifications:

  • Updated import statements across multiple files to use lodash-es instead of lodash:
    • src/Affix/Affix.tsx
    • src/Animation/Collapse.tsx
    • src/Animation/Transition.tsx
    • src/AutoComplete/AutoComplete.tsx
    • src/AutoComplete/utils.ts
    • src/Calendar/CalendarContainer.tsx [1] [2]
    • src/Calendar/Grid/GridCell.tsx
    • src/Calendar/Grid/GridHeaderRow.tsx
    • src/Calendar/TimeDropdown/TimeDropdown.tsx
    • src/CascadeTree/TreeView.tsx
    • src/Cascader/Cascader.tsx [1] [2]
    • src/CheckPicker/CheckPicker.tsx
    • src/CheckTree/CheckTreeView.tsx [1] [2]
    • src/CheckTree/hooks/useTreeCheckState.ts
    • src/CheckTree/utils.ts
    • src/CheckTreePicker/CheckTreePicker.tsx
    • src/CheckboxGroup/CheckboxGroup.tsx
    • src/Col/Col.tsx

Configuration Changes:

Copy link
codesandbox bot commented Dec 24, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link
vercel bot commented Dec 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 25, 2024 5:45am
rsuite-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 25, 2024 5:45am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
rsuite-v4 ⬜️ Ignored (Inspect) Visit Preview Dec 25, 2024 5:45am

Copy link
codesandbox-ci bot commented Dec 24, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.27%. Comparing base (b69b002) to head (0217c84).

Files with missing lines Patch % Lines
src/MaskedInput/test/adjustCaretPositionSpec.ts 80.00% 0 Missing and 1 partial ⚠️
src/MaskedInput/test/dynamicTests.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4085      +/-   ##
==========================================
- Coverage   89.30%   89.27%   -0.03%     
==========================================
  Files         517      515       -2     
  Lines       12187    12181       -6     
  Branches     3162     3163       +1     
==========================================
- Hits        10884    10875       -9     
  Misses        641      641              
- Partials      662      665       +3     
Flag Coverage Δ
ChromeCi ?
Firefox 89.27% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonguo
Copy link
Member Author

Check with Size Limit, replacing lodash with lodash-es actually increases the volume.

@simonguo simonguo added this to the v6 milestone Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0