8000 Fix `AzureOpenAIModel` to match the latest Azure API. by Yucheng-Jiang · Pull Request #309 · stanford-oval/storm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix AzureOpenAIModel to match the latest Azure API. #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 23, 2025
Merged

Fix AzureOpenAIModel to match the latest Azure API. #309

merged 12 commits into from
Jan 23, 2025

Conversation

Yucheng-Jiang
Copy link
Collaborator

No description provided.

@Yucheng-Jiang
Copy link
Collaborator Author

After review, I'll apply black to reformat the code

shaoyijia
shaoyijia previously approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator
@shaoyijia shaoyijia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@shaoyijia
Copy link
Collaborator

I would suggest updating README.md, setup.py version_number, knowledge_storm/__init__.py __version__ in this PR.

@Yucheng-Jiang Yucheng-Jiang marked this pull request as ready for review January 22, 2025 19:13
@Yucheng-Jiang
Copy link
Collaborator Author
  • Update readme
  • Bump up version number
  • Add documentation to Encoder class

Yucheng-Jiang
Yucheng-Jiang commented Jan 22, 2025
View reviewed changes
@Yucheng-Jiang Yucheng-Jiang merged commit e80d9bb into main Jan 23, 2025
1 check passed
testost pushed a commit to testost/storm that referenced this pull request Feb 8, 2025
@Yucheng-Jiang
Merge pull request stanford-oval#309 from stanford-oval/yijia-patch-a…
18bb30d 
…zuremodel

Fix `AzureOpenAIModel` to match the latest Azure API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaoyijia shaoyijia shaoyijia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yucheng-Jiang @shaoyijia
0