8000 Add image platform argument by MaxBed4d · Pull Request #53 · stackhpc/ansible-collection-openstack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

Add image platform argument #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 16, 2025
Merged

Add image platform argument #53

merged 11 commits into from
Apr 16, 2025

Conversation

MaxBed4d
Copy link
Contributor
@MaxBed4d MaxBed4d commented Feb 6, 2025

No description provided.

@MaxBed4d MaxBed4d requested a review from a team as a code owner February 6, 2025 13:29
@MaxBed4d MaxBed4d force-pushed the aarch64-image-build branch from 082b26b to 1a478b6 Compare February 7, 2025 09:44
@MaxBed4d MaxBed4d requested a review from jackhodgkiss February 7, 2025 10:03
jackhodgkiss
jackhodgkiss previously approved these changes Feb 7, 2025
View reviewed changes
MoteHue
MoteHue requested changes Feb 7, 2025
View reviewed changes
MoteHue
MoteHue reviewed Feb 7, 2025
View reviewed changes
MoteHue
MoteHue requested changes Feb 7, 2025
View reviewed changes
@MaxBed4d @MoteHue
Update roles/os_images/tasks/images.yml
3b11112 
Co-authored-by: Matt Crees <mattc@stackhpc.com>
MoteHue
MoteHue previously approved these changes Feb 7, 2025
View reviewed changes
bbezak
bbezak requested changes Feb 10, 2025
View reviewed changes
Copy link
Member
@bbezak bbezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please add this info to readme and maybe example playbook there ? let's not force people to look into the code ;)

@MaxBed4d
Copy link
Contributor Author

could you please add this info to readme and maybe example playbook there ? let's not force people to look into the code ;)

Done, added to the README.md

@MaxBed4d MaxBed4d requested a review from bbezak February 10, 2025 10:24
@MaxBed4d MaxBed4d force-pushed the aarch64-image-build branch from 97dff41 to c579189 Compare February 10, 2025 10:39
@MaxBed4d MaxBed4d force-pushed the aarch64-image-build branch from c579189 to 31ad1be Compare February 18, 2025 15:32
m-bull
m-bull reviewed Apr 1, 2025
View reviewed changes
MoteHue
MoteHue previously approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor
@MoteHue MoteHue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MaxBed4d and @m-bull, this is looking good to me

MaxBed4d and others added 3 commits April 2, 2025 12:50
@MaxBed4d @m-bull
README update for CPU Arch
c5b0d4c
@m-bull
Separate architecture from properties.cpu_arch
134b141 
Allow both to be independent, but retain the original
behaviour of setting cpu_arch: "x86_64" when no
architecture is provided.
@m-bull
Simplify documentation and note architecture/cpu_arch split
9191ae7
8000
@m-bull m-bull force-pushed the aarch64-image-build branch from 56d0647 to 9191ae7 Compare April 2, 2025 11:51
MoteHue
MoteHue previously approved these changes Apr 2, 2025
View reviewed changes
@m-bull m-bull force-pushed the aarch64-image-build branch from 5e02131 to 9727c01 Compare April 4, 2025 14:58
m-bull added 3 commits April 4, 2025 16:32
@m-bull
Make arm64/aarch64 and x86_64 first-class citizens for images
c107248 
Detect their glance cpu_arch property directly from their
architecture.
@m-bull
Fixup README
25d22ff
@m-bull
Run multiarch/qemu-user-static image for cross-arch
8ecd7ef 
This approach is taken in Kolla CI and Kayobe for building
cross-arch OCI images, reuse it here.
@m-bull m-bull force-pushed the aarch64-image-build branch from 9727c01 to 8ecd7ef Compare April 4, 2025 15:32
bbezak
bbezak approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member
@bbezak bbezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. thx chaps

@m-bull m-bull merged commit 1d5bade into main Apr 16, 2025
4 checks passed
@m-bull m-bull deleted the aarch64-image-build branch April 16, 2025 09:18
@cityofships cityofships added the arm64 Work related to ARM architecture support label Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-bull m-bull m-bull left review comments

@bbezak bbezak bbezak approved these changes

@MoteHue MoteHue MoteHue left review comments

@jackhodgkiss jackhodgkiss 6019 jackhodgkiss left review comments

@Alex-Welsh Alex-Welsh Awaiting requested review from Alex-Welsh

Assignees
No one assigned
Labels
arm64 Work related to ARM architecture support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MaxBed4d @m-bull @bbezak @MoteHue @jackhodgkiss @cityofships
0