feat: set TOOLHIVE_SECRETS_PROVIDER=none for K8s proxy runner pods #684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add TOOLHIVE_SECRETS_PROVIDER=none environment variable to all proxy runner pods created by the operator - Ensures proper secrets provider configuration for Kubernetes deployments - Add test to verify the environment variable is correctly set - Maintains backwards compatibility with existing MCPServer configurations
ChrisJBurns
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
TOOLHIVE_SECRETS_PROVIDER=noneenvironment variable to all proxy runner pods created by the thv-operator in Kubernetes.Changes
mcpserver_controller.goto automatically setTOOLHIVE_SECRETS_PROVIDER=nonefor all proxy runner podsTestDeploymentForMCPServerSecretsProviderEnvto verify the environment variable is correctly setTesting
Related
This addresses the requirement to set the TOOLHIVE_SECRETS_PROVIDER environment variable to
nonewhen running in Kubernetes environments.