Ensure proxy process is killed during workload delete #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, the delete workload was changed to not call the StopWorkload method since the runtime kill running containers for us. However, the call to delete the proxy runner was left out, leaving orphaned processes. This change will kill the proxy process if it is running.
lujunsan
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, DeleteWorkload was changed to not call the StopWorkload method. This was because the runtime will kill running containers for us. However, the call to delete the proxy runner process was deleted by mistake, leaving orphaned processes after workload deletion. This change will ensure the proxy runner process is cleaned up as part of deletion.