8000 Added poseidon mix_u64 regression test. by Alon-Ti · Pull Request #983 · starkware-libs/stwo-cairo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added poseidon mix_u64 regression test. #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: poseidon_verifier_3
Choose a base branch
from
Open

Added poseidon mix_u64 regression test. #983

wants to merge 1 commit into from

Conversation

Alon-Ti
Copy link
Contributor
@Alon-Ti Alon-Ti commented Jun 9, 2025 •
edited by phil-starkware
Loading

This change is Reviewable

@Alon-Ti Alon-Ti mentioned this pull request Jun 9, 2025
Open
@Alon-Ti Graphite App
Copy link
Contributor Author
Alon-Ti commented Jun 9, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Alon-Ti Alon-Ti mentioned this pull request Jun 9, 2025
Open
@Alon-Ti Alon-Ti requested a review from anatgstarkware June 9, 2025 12:50
@Alon-Ti Alon-Ti marked this pull request as ready for review June 9, 2025 12:50
@anatgstarkware
Copy link
Contributor

stwo_cairo_verifier/crates/verifier_core/src/channel/poseidon252.cairo line 283 at r1 (raw file):

        assert_eq!(
            channel.digest, 0x07cecc0ee3d858c843fe63165f038353f9f80f52dd8d32eead9f635e2f7d8b8e,

Is this from stwo?

Code quote:

0x07cecc0ee3d858c843fe63165f038353f9f80f52dd8d32eead9f635e2f7d8b8e

Alon-Ti
Alon-Ti commented Jun 15, 2025
View reviewed changes
Copy link
Contributor Author
@Alon-Ti Alon-Ti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @anatgstarkware)

stwo_cairo_verifier/crates/verifier_core/src/channel/poseidon252.cairo line 283 at r1 (raw file):

Previously, anatgstarkware (anatg) wrote…

Is this from stwo?

Yes:
https://github.com/starkware-libs/stwo/blob/b5e8e1ab3f4638a48eeb6aa059ea0b40e289c7b3/crates/prover/src/core/channel/poseidon252.rs#L220

anatgstarkware
anatgstarkware approved these changes Jun 15, 2025
< 8000 span class="Button-content"> View reviewed changes
Copy link
Contributor
@anatgstarkware anatgstarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved

anatgstarkware
anatgstarkware approved these changes Jun 15, 2025
View reviewed changes
Copy link
Contributor
@anatgstarkware anatgstarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Alon-Ti)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anatgstarkware anatgstarkware anatgstarkware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alon-Ti @anatgstarkware
0