8000 chore: fix JavaScript lint errors (issue #6577) by Swapnil-2502 · Pull Request #7096 · stdlib-js/stdlib · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: fix JavaScript lint errors (issue #6577) #7096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 27, 2025
Merged

chore: fix JavaScript lint errors (issue #6577) #7096

merged 5 commits into from
May 27, 2025

Conversation

Swapnil-2502
Copy link
Contributor
@Swapnil-2502 Swapnil-2502 commented May 26, 2025 •
edited
Loading

Resolves #6577.

Description

What is the purpose of this pull request?

This pull request:

  • Fixes JavaScript lint errors in Linting file: Linting file: lib/node_modules/@stdlib/datasets/sotu/scripts/build.js
  • 524:8 error Using the new Array() constructor is not allowed; use an array literal with push instead stdlib/no-new-array

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or impl 8000 ementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor
stdlib-bot commented May 26, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
datasets/sotu $\color{green}1725/1725$
$\color{green}+100.00\%$ 		$\color{green}106/106$
$\color{green}+100.00\%$ 		$\color{green}11/11$
$\color{green}+100.00\%$ 		$\color{green}1725/1725$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Swapnil-2502 Swapnil-2502 changed the title fix JavaScript lint errors #6577 chore: fix JavaScript lint errors (issue #6577) May 26, 2025
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label May 26, 2025
Planeshifter
Planeshifter reviewed May 27, 2025
View reviewed changes
@Planeshifter
style: add spaces around parentheses
1075cdf 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
Planeshifter approved these changes May 27, 2025
View reviewed changes
Copy link
Member
@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label May 27, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

chore: fix JavaScript lint errors (issue #6577)

PR-URL: https://github.com/stdlib-js/stdlib/pull/7096
Closes: https://github.com/stdlib-js/stdlib/issues/6577

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: Swapnil-2502 <hajareswapnil.2502@gmail.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 653a7a0 into stdlib-js:develop May 27, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors
3 participants
@Swapnil-2502 @stdlib-bot @Planeshifter
0