perf: symlink instead of copy all items from specific version to GOROOT #20
Conversation
|
Hi @jimeh Thanks for taking your time with this. Pretty neat you took the upgrade process into consideration. ❤️ I actually started crafting I also cannot tell if it was something very specific to the extension I was using or a more general problem that could affect other workflows. Now, this was back in early 2018, so I would assume I got these errors with So, we would need to test this thoroughly to ensure the issues I had 3 years ago are no longer relevant. I will try to replicate the issues I had using I will get back to you once I test. Thanks again for your time. |
|
Let me know if there's anything I might be able to help with :) For what's its worth though, I've personally been using the symlink method here since I submitted this PR with Go 1.16 and 1.16.2. Though I use Emacs and format code via gopls' language server command or 3rd party tools like |
|
@jimeh so I tested I only tested with the official golang VS Code extension because there're really no other VS Code extensions with decent usage out there. Then I pulled your changes locally and tested again with Based on that and your own experience, I think we can give this a go. I pushed some new stuff so gonna ask you to rebase your branch to get the latest and for the CI to run the (freshly added) tests. Also, if you don't mind, put these changes in the CHANGELOG.md as part of your commit. |
The gaols here are: - Make `g set <version>` much faster, as it no longer needs to delete and copy around 400MB / 10,000 files. Instead it just updates 20 symlinks. - Avoid the need to execute `rm -rf ...` as that always makes me nervous. The old `rm -rf ...` command is still present in the event that the target file/folder for the new symlink is a file or folder instead of a symlink. This is required to enable a seamless upgrade from the old method of populating GOROOT. A for loop was needed to iterate over the each binary in the source version's `bin` folder, as `$GOROOT/bin` is now a symlink, the old `"$GOROOT/bin/"*` expansion no longer worked correctly.
0d1f4f1 to
2730dc2
Compare
|
Awesome :) I've rebased, and updated the changelog. Don't hesitate if there's anything else you want me to fix/change/etc :) |
- Improve switching Go versions performance to nearly instant (#19, thanks @jimeh) - Add support for darwin-arm64 (M1 chips) (#20, thanks @joelanford) - Tweak docs, guidelines, and configs to make it easier to contribute - Format all documents with Prettier for consistency - Add Github template for BUG reports - Update screencast with more recent version of g
The gaols here are:
g set <version>much faster, as it no longer needs to deleteand copy around 400MB / 10,000 files. Instead it just updates 20
symlinks.
rm -rf ...as that always makes menervous. The old
rm -rf ...command is still present in the eventthat the target file/folder for the new symlink is a file or folder
instead of a symlink. This is required to enable a seamless upgrade
from the old method of populating GOROOT.
A for loop was needed to iterate over the each binary in the source
version's
binfolder, as$GOROOT/binis now a symlink, the old"$GOROOT/bin/"*expansion no longer worked correctly.Apologies if this kind of behavior/change has been discussed in the past, I've had a poke around issues and PRs, but couldn't spot anything. Hopefully I'm not blind :)
I should mention that I've only tested this on macOS (Big Sur) for now, but I'm happy to test it on Linux too.