ASCII extraction #2941
Open
ASCII extraction #2941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2941 +/- ##
=======================================
Coverage 99.89% 99.89%
=======================================
Files 362 362
Lines 51685 51685
=======================================
Hits 51633 51633
Misses 52 52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I also found the extraction in the tutorials, and have taken the opportunity to add driver compilation to the tutorial. I had to remove
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an ASCII extraction library. I have also added an example for extraction of generic kernels (though atm we can't create drivers for it. I know I had nemo extraction+driver hacked in the past to work (hence this example that I never committed). With the work on moving to PSyIR (#1010) and refactoring kernel extraction into a common base class, we should be very close to also allow driver creation here.