added renegotiated sales to sales_filter #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
O patch parece correto, mas nós não usamos o github para mergear o código, pois ele precisa ser testado automaticamente pelo gerrit/jenkins. Rodrigo, vc poderia usar o 'git review' para enviar as mudanças? (pode ser necessário instalar o pacote git-review antes) |
|
Eu enviei o patch para revisão aqui: http://gerrit.async.com.br/#/c/986/ |
|
Na realidade, eu não tinha visto que o @jdahlin tinha enviado o patch já aqui: http://gerrit.async.com.br/#/c/982 Abandonei o que eu enviei em função disso |
202c5b7 to
2b6a922
Compare
edcb4ce to
2b6a922
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uma venda renegociada deve continuar sendo filtrada como "Vendido" no aplicativo Vendas.
Fiz somente um teste funcional e está funcionando.
rodrigo_neemo