fix: infinite recursion with unknown attestation #36
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
There was a problem hiding this comment.
in all honesty, I don't think I fully understand how all of this works so I adapted the test from the ucanto PR. It is passing, but I may be messing something up, please review carefully.
There was a problem hiding this comment.
The test is checking that validation fails due to the attestation being issued by a different service (othersvc) - we don't trust attestations issued by other services. It's not invalid, just irrelevant. We're not able to resolve did:mailto:web.mail:alice because there's no attestation we can use that makes it valid.
If you don't take the delegation that's being verified out of the list and it happens to need an attestation that doesn't exist then it'll just keep recursing - trying to find an attestation for the same delegation over and over.
Part of #35
This PR ports the changes added to the JS ucanto library here: storacha/ucanto#368